Title: [173531] trunk
Revision
173531
Author
[email protected]
Date
2014-09-11 12:37:29 -0700 (Thu, 11 Sep 2014)

Log Message

[CSS Font Loading] Enable CSS Font Loading on Mac
https://bugs.webkit.org/show_bug.cgi?id=135473

Reviewed by Antti Koivisto.

Source/_javascript_Core:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable CSS Font Loading in FeatureDefines, and in
RuntimeEnabledFeatures.

Font Loading tests have been toggled back on in the Mac
TestExpectations file.

* Configurations/FeatureDefines.xcconfig:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

Source/WebKit/mac:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Enable tests on the Mac platform. As more platforms
are added, this should move from the tests defaulting
to disabled to the tests defaulting to enabled.

* platform/mac/TestExpectations: Mark the Font Loading
tests as enabled.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (173530 => 173531)


--- trunk/LayoutTests/ChangeLog	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/LayoutTests/ChangeLog	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1,3 +1,17 @@
+2014-09-11  Bear Travis  <[email protected]>
+
+        [CSS Font Loading] Enable CSS Font Loading on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=135473
+
+        Reviewed by Antti Koivisto.
+
+        Enable tests on the Mac platform. As more platforms
+        are added, this should move from the tests defaulting
+        to disabled to the tests defaulting to enabled.
+
+        * platform/mac/TestExpectations: Mark the Font Loading
+        tests as enabled.
+
 2014-09-11  Roger Fong  <[email protected]>
 
         Temporary change to determine why some snapshotting tests are failing only on bots.

Modified: trunk/LayoutTests/platform/mac/TestExpectations (173530 => 173531)


--- trunk/LayoutTests/platform/mac/TestExpectations	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1374,6 +1374,16 @@
 webkit.org/b/121995 media/video-controls-captions-trackmenu-hide-on-click.html [ Timeout Failure ]
 webkit.org/b/121995 media/video-controls-captions-trackmenu-includes-enabled-track.html [ Timeout Failure ]
 
+# CSS Font Loading is only enabled on Mac, and tests are not run by default
+webkit.org/b/135390 fast/css/fontloader-download-error.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-events.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-loadingdone.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-faces-download-error.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-faces.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-multiple-families.html [ Pass ]
+webkit.org/b/135390 fast/css/fontloader-page-cache.html [ Pass ]
+webkit.org/b/135390 http/tests/webfont/fontloader-loading-attribute.html [ Pass ]
+
 # REGRESSION(r156546): 7 media tests broken (122021)
 webkit.org/b/122021 media/track/track-cue-mutable-text.html
 webkit.org/b/122021 media/track/track-cue-rendering-mode-changed.html

Modified: trunk/Source/_javascript_Core/ChangeLog (173530 => 173531)


--- trunk/Source/_javascript_Core/ChangeLog	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1,3 +1,14 @@
+2014-09-11  Bear Travis  <[email protected]>
+
+        [CSS Font Loading] Enable CSS Font Loading on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=135473
+
+        Reviewed by Antti Koivisto.
+
+        Enable CSS Font Loading in FeatureDefines.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2014-09-11  Joseph Pecoraro  <[email protected]>
 
         Unreviewed rebaseline of inspector generator test results after r173120.

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (173530 => 173531)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2014-09-11 19:37:29 UTC (rev 173531)
@@ -82,7 +82,7 @@
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
-ENABLE_FONT_LOAD_EVENTS = ;
+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
 ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
 ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
 ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));

Modified: trunk/Source/WebCore/ChangeLog (173530 => 173531)


--- trunk/Source/WebCore/ChangeLog	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/ChangeLog	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1,3 +1,20 @@
+2014-09-11  Bear Travis  <[email protected]>
+
+        [CSS Font Loading] Enable CSS Font Loading on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=135473
+
+        Reviewed by Antti Koivisto.
+
+        Enable CSS Font Loading in FeatureDefines, and in
+        RuntimeEnabledFeatures.
+
+        Font Loading tests have been toggled back on in the Mac
+        TestExpectations file.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * bindings/generic/RuntimeEnabledFeatures.cpp:
+        (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
+
 2014-09-11  Chris Dumez  <[email protected]>
 
         Use tighter typing for Document::ownerElement() return value

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (173530 => 173531)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2014-09-11 19:37:29 UTC (rev 173531)
@@ -82,7 +82,7 @@
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
-ENABLE_FONT_LOAD_EVENTS = ;
+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
 ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
 ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
 ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));

Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (173530 => 173531)


--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2014-09-11 19:37:29 UTC (rev 173531)
@@ -95,7 +95,7 @@
     , m_areExperimentalContentSecurityPolicyFeaturesEnabled(false)
 #endif
 #if ENABLE(FONT_LOAD_EVENTS)
-    , m_isFontLoadEventsEnabled(false)
+    , m_isFontLoadEventsEnabled(true)
 #endif
 #if ENABLE(GAMEPAD)
     , m_areGamepadsEnabled(false)

Modified: trunk/Source/WebKit/mac/ChangeLog (173530 => 173531)


--- trunk/Source/WebKit/mac/ChangeLog	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1,3 +1,14 @@
+2014-09-11  Bear Travis  <[email protected]>
+
+        [CSS Font Loading] Enable CSS Font Loading on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=135473
+
+        Reviewed by Antti Koivisto.
+
+        Enable CSS Font Loading in FeatureDefines.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2014-09-11  Beth Dakin  <[email protected]>
 
         Support rubber-banding in sub-frames

Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (173530 => 173531)


--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2014-09-11 19:37:29 UTC (rev 173531)
@@ -82,7 +82,7 @@
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
-ENABLE_FONT_LOAD_EVENTS = ;
+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
 ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
 ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
 ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));

Modified: trunk/Source/WebKit2/ChangeLog (173530 => 173531)


--- trunk/Source/WebKit2/ChangeLog	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit2/ChangeLog	2014-09-11 19:37:29 UTC (rev 173531)
@@ -1,3 +1,14 @@
+2014-09-11  Bear Travis  <[email protected]>
+
+        [CSS Font Loading] Enable CSS Font Loading on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=135473
+
+        Reviewed by Antti Koivisto.
+
+        Enable CSS Font Loading in FeatureDefines.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2014-09-11  Youenn Fablet  <[email protected]>
 
         [WK2] Authentication dialog is displayed for cross-origin XHR

Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (173530 => 173531)


--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2014-09-11 19:34:17 UTC (rev 173530)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2014-09-11 19:37:29 UTC (rev 173531)
@@ -82,7 +82,7 @@
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1080 = ;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_1090 = ENABLE_ENCRYPTED_MEDIA_V2;
 ENABLE_ENCRYPTED_MEDIA_V2_macosx_101000 = ENABLE_ENCRYPTED_MEDIA_V2;
-ENABLE_FONT_LOAD_EVENTS = ;
+ENABLE_FONT_LOAD_EVENTS = ENABLE_FONT_LOAD_EVENTS;
 ENABLE_FULLSCREEN_API = $(ENABLE_FULLSCREEN_API_$(PLATFORM_NAME));
 ENABLE_FULLSCREEN_API_macosx = ENABLE_FULLSCREEN_API;
 ENABLE_GAMEPAD = $(ENABLE_GAMEPAD_$(PLATFORM_NAME));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to