Title: [173559] trunk/Source/WebCore
- Revision
- 173559
- Author
- [email protected]
- Date
- 2014-09-12 08:44:42 -0700 (Fri, 12 Sep 2014)
Log Message
REGRESSION(r173441): [GTK] All buttons appear insensitive
https://bugs.webkit.org/show_bug.cgi?id=136614
Reviewed by Sergio Villar Senin.
Do not use RenderTheme::isReadOnlyControl() to decide whether to
render non text based forms sensitive or unsensitive, isEnabled()
is enough in those cases.
* rendering/RenderThemeGtk.cpp:
(WebCore::paintToggle):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173558 => 173559)
--- trunk/Source/WebCore/ChangeLog 2014-09-12 15:42:11 UTC (rev 173558)
+++ trunk/Source/WebCore/ChangeLog 2014-09-12 15:44:42 UTC (rev 173559)
@@ -1,5 +1,22 @@
2014-09-12 Carlos Garcia Campos <[email protected]>
+ REGRESSION(r173441): [GTK] All buttons appear insensitive
+ https://bugs.webkit.org/show_bug.cgi?id=136614
+
+ Reviewed by Sergio Villar Senin.
+
+ Do not use RenderTheme::isReadOnlyControl() to decide whether to
+ render non text based forms sensitive or unsensitive, isEnabled()
+ is enough in those cases.
+
+ * rendering/RenderThemeGtk.cpp:
+ (WebCore::paintToggle):
+ (WebCore::renderButton):
+ (WebCore::RenderThemeGtk::paintSliderTrack):
+ (WebCore::RenderThemeGtk::paintSliderThumb):
+
+2014-09-12 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
https://bugs.webkit.org/show_bug.cgi?id=136669
Modified: trunk/Source/WebCore/rendering/RenderThemeGtk.cpp (173558 => 173559)
--- trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2014-09-12 15:42:11 UTC (rev 173558)
+++ trunk/Source/WebCore/rendering/RenderThemeGtk.cpp 2014-09-12 15:44:42 UTC (rev 173559)
@@ -515,7 +515,7 @@
gtk_style_context_add_class(context, widgetType == GTK_TYPE_CHECK_BUTTON ? GTK_STYLE_CLASS_CHECK : GTK_STYLE_CLASS_RADIO);
guint flags = 0;
- if (!theme->isEnabled(renderObject) || theme->isReadOnlyControl(renderObject))
+ if (!theme->isEnabled(renderObject))
flags |= GTK_STATE_FLAG_INSENSITIVE;
else if (theme->isHovered(renderObject))
flags |= GTK_STATE_FLAG_PRELIGHT;
@@ -575,7 +575,7 @@
IntRect buttonRect(rect);
guint flags = 0;
- if (!theme->isEnabled(renderObject) || theme->isReadOnlyControl(renderObject))
+ if (!theme->isEnabled(renderObject))
flags |= GTK_STATE_FLAG_INSENSITIVE;
else if (theme->isHovered(renderObject))
flags |= GTK_STATE_FLAG_PRELIGHT;
@@ -1105,7 +1105,7 @@
applySliderStyleContextClasses(context, part);
gtk_style_context_add_class(context, GTK_STYLE_CLASS_TROUGH);
- if (!isEnabled(renderObject) || isReadOnlyControl(renderObject))
+ if (!isEnabled(renderObject))
gtk_style_context_set_state(context, GTK_STATE_FLAG_INSENSITIVE);
gtk_render_background(context, paintInfo.context->platformContext()->cr(), rect.x(), rect.y(), rect.width(), rect.height());
@@ -1136,7 +1136,7 @@
gtk_style_context_add_class(context, GTK_STYLE_CLASS_SLIDER);
guint flags = 0;
- if (!isEnabled(renderObject) || isReadOnlyControl(renderObject))
+ if (!isEnabled(renderObject))
flags |= GTK_STATE_FLAG_INSENSITIVE;
else if (isHovered(renderObject))
flags |= GTK_STATE_FLAG_PRELIGHT;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
