Title: [173579] trunk/Source/WebCore
- Revision
- 173579
- Author
- [email protected]
- Date
- 2014-09-12 14:43:00 -0700 (Fri, 12 Sep 2014)
Log Message
Unprefix the flexbox CSS properties
https://bugs.webkit.org/show_bug.cgi?id=98420
Unreviewed fix up, that missed the original
commit. Tony Chang made some comments
on the bugzilla.
"justify-self" should not have been unprefixed.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173578 => 173579)
--- trunk/Source/WebCore/ChangeLog 2014-09-12 21:31:30 UTC (rev 173578)
+++ trunk/Source/WebCore/ChangeLog 2014-09-12 21:43:00 UTC (rev 173579)
@@ -33,6 +33,26 @@
Unprefix the flexbox CSS properties
https://bugs.webkit.org/show_bug.cgi?id=98420
+ Unreviewed fix up, that missed the original
+ commit. Tony Chang made some comments
+ on the bugzilla.
+
+ "justify-self" should not have been unprefixed.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/CSSParser.cpp:
+ (WebCore::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParser::parseValue):
+ * css/CSSPropertyNames.in:
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::applyProperty):
+
+2014-09-12 Dean Jackson <[email protected]>
+
+ Unprefix the flexbox CSS properties
+ https://bugs.webkit.org/show_bug.cgi?id=98420
+
Reviewed by Benjamin Poulain.
Remove the need for a "-webkit-" prefix on flexbox
@@ -47,7 +67,7 @@
- flex-shrink
- flex
- flex-flow
- - justify
+ - justify-content
- order
... as well as the display keyword values "flex" and
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (173578 => 173579)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-09-12 21:31:30 UTC (rev 173578)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2014-09-12 21:43:00 UTC (rev 173579)
@@ -289,7 +289,7 @@
CSSPropertyFlexDirection,
CSSPropertyFlexWrap,
CSSPropertyJustifyContent,
- CSSPropertyJustifySelf,
+ CSSPropertyWebkitJustifySelf,
CSSPropertyWebkitFilter,
CSSPropertyWebkitFontKerning,
CSSPropertyWebkitFontSmoothing,
@@ -2054,7 +2054,7 @@
return cssValuePool().createValue(style->flexWrap());
case CSSPropertyJustifyContent:
return cssValuePool().createValue(style->justifyContent());
- case CSSPropertyJustifySelf: {
+ case CSSPropertyWebkitJustifySelf: {
RefPtr<CSSValueList> result = CSSValueList::createSpaceSeparated();
result->append(CSSPrimitiveValue::create(style->justifySelf()));
if (style->justifySelf() >= JustifySelfCenter && style->justifySelfOverflowAlignment() != JustifySelfOverflowAlignmentDefault)
Modified: trunk/Source/WebCore/css/CSSParser.cpp (173578 => 173579)
--- trunk/Source/WebCore/css/CSSParser.cpp 2014-09-12 21:31:30 UTC (rev 173578)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2014-09-12 21:43:00 UTC (rev 173579)
@@ -891,7 +891,7 @@
if (valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueSpaceBetween || valueID == CSSValueSpaceAround)
return true;
break;
- case CSSPropertyJustifySelf:
+ case CSSPropertyWebkitJustifySelf:
if (valueID == CSSValueAuto || valueID == CSSValueFlexStart || valueID == CSSValueFlexEnd || valueID == CSSValueCenter || valueID == CSSValueBaseline || valueID == CSSValueStretch)
return true;
break;
@@ -2615,7 +2615,7 @@
}
return false;
}
- case CSSPropertyJustifySelf:
+ case CSSPropertyWebkitJustifySelf:
return parseJustifySelf(propId, important);
#if ENABLE(CSS_GRID_LAYOUT)
case CSSPropertyWebkitGridAutoColumns:
Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (173578 => 173579)
--- trunk/Source/WebCore/css/CSSPropertyNames.in 2014-09-12 21:31:30 UTC (rev 173578)
+++ trunk/Source/WebCore/css/CSSPropertyNames.in 2014-09-12 21:43:00 UTC (rev 173579)
@@ -315,8 +315,7 @@
-webkit-flex-wrap = flex-wrap
justify-content
-webkit-justify-content = justify-content
-justify-self
--webkit-justify-self = justify-self
+-webkit-justify-self
-webkit-font-size-delta
#if defined(ENABLE_CSS_GRID_LAYOUT) && ENABLE_CSS_GRID_LAYOUT
-webkit-grid
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (173578 => 173579)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-12 21:31:30 UTC (rev 173578)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-12 21:43:00 UTC (rev 173579)
@@ -2839,7 +2839,7 @@
return;
}
#endif /* ENABLE(CSS_GRID_LAYOUT) */
- case CSSPropertyJustifySelf: {
+ case CSSPropertyWebkitJustifySelf: {
HANDLE_INHERIT_AND_INITIAL(justifySelf, JustifySelf);
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
if (Pair* pairValue = primitiveValue->getPairValue()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
