Title: [173613] trunk/Source/WebCore
- Revision
- 173613
- Author
- cdu...@apple.com
- Date
- 2014-09-14 22:40:56 -0700 (Sun, 14 Sep 2014)
Log Message
Fix post-mortem nits for r173528 & r173549
https://bugs.webkit.org/show_bug.cgi?id=136808
Reviewed by Darin Adler.
Fix post-mortem nits for r173528 & r173549.
No new tests, no behavior change.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
- Use auto* instead of more specific types.
- Use fastGetAttribute() instead of getAttribute() as this is
supported for the "title" attribute.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):
Use auto* instead of more specific types.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173612 => 173613)
--- trunk/Source/WebCore/ChangeLog 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/ChangeLog 2014-09-15 05:40:56 UTC (rev 173613)
@@ -1,3 +1,24 @@
+2014-09-14 Christophe Dumez <cdu...@apple.com>
+
+ Fix post-mortem nits for r173528 & r173549
+ https://bugs.webkit.org/show_bug.cgi?id=136808
+
+ Reviewed by Darin Adler.
+
+ Fix post-mortem nits for r173528 & r173549.
+
+ No new tests, no behavior change.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
+ - Use auto* instead of more specific types.
+ - Use fastGetAttribute() instead of getAttribute() as this is
+ supported for the "title" attribute.
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::setSelectionFromNone):
+ Use auto* instead of more specific types.
+
2014-09-14 Gyuyoung Kim <gyuyoung....@samsung.com>
Introduce FONT_DATA_TYPE_CASTS, and use it
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (173612 => 173613)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-09-15 05:40:56 UTC (rev 173613)
@@ -1461,9 +1461,9 @@
return ariaLabel;
}
- if (HTMLFrameOwnerElement* owner = document->ownerElement()) {
+ if (auto* owner = document->ownerElement()) {
if (owner->hasTagName(frameTag) || owner->hasTagName(iframeTag)) {
- const AtomicString& title = owner->getAttribute(titleAttr);
+ const AtomicString& title = owner->fastGetAttribute(titleAttr);
if (!title.isEmpty())
return title;
}
@@ -1474,7 +1474,7 @@
if (!documentTitle.isEmpty())
return documentTitle;
- if (HTMLElement* body = document->body())
+ if (auto* body = document->body())
return body->getNameAttribute();
return String();
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (173612 => 173613)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-15 04:29:26 UTC (rev 173612)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2014-09-15 05:40:56 UTC (rev 173613)
@@ -2112,7 +2112,7 @@
return;
#endif
- Element* documentElement = document->documentElement();
+ auto* documentElement = document->documentElement();
if (!documentElement)
return;
if (auto body = childrenOfType<HTMLBodyElement>(*documentElement).first())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
