Title: [173643] trunk/Source/WebCore
- Revision
- 173643
- Author
- [email protected]
- Date
- 2014-09-15 18:15:36 -0700 (Mon, 15 Sep 2014)
Log Message
Un-inline the Node constructor
https://bugs.webkit.org/show_bug.cgi?id=136842
Reviewed by Benjamin Poulain.
Un-inline the Node constructor as it does not seem to impact
performance, based on my testing:
http://dromaeo.com/?id=226992,226998
This reduces the stripped binary size by ~4Kb.
No new tests, no behavior change.
* dom/Document.h:
(WebCore::Node::Node): Deleted.
* dom/Node.cpp:
(WebCore::Node::Node):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173642 => 173643)
--- trunk/Source/WebCore/ChangeLog 2014-09-16 00:45:04 UTC (rev 173642)
+++ trunk/Source/WebCore/ChangeLog 2014-09-16 01:15:36 UTC (rev 173643)
@@ -1,3 +1,23 @@
+2014-09-15 Chris Dumez <[email protected]>
+
+ Un-inline the Node constructor
+ https://bugs.webkit.org/show_bug.cgi?id=136842
+
+ Reviewed by Benjamin Poulain.
+
+ Un-inline the Node constructor as it does not seem to impact
+ performance, based on my testing:
+ http://dromaeo.com/?id=226992,226998
+
+ This reduces the stripped binary size by ~4Kb.
+
+ No new tests, no behavior change.
+
+ * dom/Document.h:
+ (WebCore::Node::Node): Deleted.
+ * dom/Node.cpp:
+ (WebCore::Node::Node):
+
2014-09-15 Shivakumar JM <[email protected]>
Web Core: Websocket state should be set to closed in didReceiveMessage call back.
Modified: trunk/Source/WebCore/dom/Document.h (173642 => 173643)
--- trunk/Source/WebCore/dom/Document.h 2014-09-16 00:45:04 UTC (rev 173642)
+++ trunk/Source/WebCore/dom/Document.h 2014-09-16 01:15:36 UTC (rev 173643)
@@ -1728,20 +1728,6 @@
return this == &document();
}
-inline Node::Node(Document& document, ConstructionType type)
- : m_nodeFlags(type)
- , m_parentNode(0)
- , m_treeScope(&document)
- , m_previous(0)
- , m_next(0)
-{
- document.incrementReferencingNodeCount();
-
-#if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS) && DUMP_NODE_STATISTICS)
- trackForDebugging();
-#endif
-}
-
inline ScriptExecutionContext* Node::scriptExecutionContext() const
{
return &document();
Modified: trunk/Source/WebCore/dom/Node.cpp (173642 => 173643)
--- trunk/Source/WebCore/dom/Node.cpp 2014-09-16 00:45:04 UTC (rev 173642)
+++ trunk/Source/WebCore/dom/Node.cpp 2014-09-16 01:15:36 UTC (rev 173643)
@@ -287,6 +287,20 @@
#endif
}
+Node::Node(Document& document, ConstructionType type)
+ : m_nodeFlags(type)
+ , m_parentNode(nullptr)
+ , m_treeScope(&document)
+ , m_previous(nullptr)
+ , m_next(nullptr)
+{
+ document.incrementReferencingNodeCount();
+
+#if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS) && DUMP_NODE_STATISTICS)
+ trackForDebugging();
+#endif
+}
+
Node::~Node()
{
#ifndef NDEBUG
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
