Title: [173654] trunk
- Revision
- 173654
- Author
- [email protected]
- Date
- 2014-09-16 01:46:10 -0700 (Tue, 16 Sep 2014)
Log Message
[GStreamer] http/tests/media/video-auth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=126619
Patch by Youenn Fablet <[email protected]> on 2014-09-16
Reviewed by Philippe Normand.
Source/WebCore:
Test: http/tests/media/video-auth-cors.html
Use stored credentials when retrieving videos following image loading behavior
(i.e. stored credentials are always used except when in cors anonymous mode),
except that requesting credentials from user remains disabled for cross-origin requests.
Patch is covered by http/tests/media/video-auth.html.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.
LayoutTests:
* platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/efl/http/tests/media/video-auth-expected.txt: Added.
* platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
* platform/gtk/http/tests/media/video-auth-expected.txt: Added.
Modified Paths
Added Paths
Property Changed
Diff
Modified: trunk/LayoutTests/ChangeLog (173653 => 173654)
--- trunk/LayoutTests/ChangeLog 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/ChangeLog 2014-09-16 08:46:10 UTC (rev 173654)
@@ -1,3 +1,15 @@
+2014-09-16 Youenn Fablet <[email protected]>
+
+ [GStreamer] http/tests/media/video-auth.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=126619
+
+ Reviewed by Philippe Normand.
+
+ * platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+ * platform/efl/http/tests/media/video-auth-expected.txt: Added.
+ * platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
+ * platform/gtk/http/tests/media/video-auth-expected.txt: Added.
+
2014-09-16 Jinho Bang <[email protected]>
Add version of drawFocusIfNeeded that take a Path2D parameter.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (173653 => 173654)
--- trunk/LayoutTests/platform/efl/TestExpectations 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2014-09-16 08:46:10 UTC (rev 173654)
@@ -1821,8 +1821,6 @@
webkit.org/b/127489 http/tests/misc/will-send-request-returns-null-on-redirect.html [ Failure ]
-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
webkit.org/b/127725 media/video-restricted-no-preload-auto.html [ Failure ]
webkit.org/b/127731 plugins/embed-prefers-plugins-for-images.html [ Failure ]
Added: trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt (0 => 173654)
--- trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt 2014-09-16 08:46:10 UTC (rev 173654)
@@ -0,0 +1,6 @@
+didReceiveAuthenticationChallenge - Responding with username:password
+
+Tests that the media player sends authorization credentials when requesting a media file.
+EVENT(canplay)
+END OF TEST
+
Property changes on: trunk/LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt
___________________________________________________________________
Added: svn:executable
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (173653 => 173654)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-09-16 08:46:10 UTC (rev 173654)
@@ -1852,8 +1852,6 @@
webkit.org/b/125406 fast/regions/relative-in-absolute-borders-overflow.html [ ImageOnlyFailure ]
-webkit.org/b/126619 http/tests/media/video-auth.html [ Failure ]
-
# Subpixel rendering: borders are reporting float values.
webkit.org/b/128061 fast/css/bidi-override-in-anonymous-block.html [ Failure ]
webkit.org/b/128061 fast/repaint/repaint-during-scroll-with-zoom.html [ Failure ]
Property changes on: trunk/LayoutTests/platform/gtk/TestExpectations
___________________________________________________________________
Added: svn:executable
Added: trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt (0 => 173654)
--- trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt 2014-09-16 08:46:10 UTC (rev 173654)
@@ -0,0 +1,6 @@
+didReceiveAuthenticationChallenge - Responding with username:password
+
+Tests that the media player sends authorization credentials when requesting a media file.
+EVENT(canplay)
+END OF TEST
+
Property changes on: trunk/LayoutTests/platform/gtk/http/tests/media/video-auth-expected.txt
___________________________________________________________________
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (173653 => 173654)
--- trunk/Source/WebCore/ChangeLog 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/Source/WebCore/ChangeLog 2014-09-16 08:46:10 UTC (rev 173654)
@@ -1,3 +1,21 @@
+2014-09-16 Youenn Fablet <[email protected]>
+
+ [GStreamer] http/tests/media/video-auth.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=126619
+
+ Reviewed by Philippe Normand.
+
+ Test: http/tests/media/video-auth-cors.html
+
+ Use stored credentials when retrieving videos following image loading behavior
+ (i.e. stored credentials are always used except when in cors anonymous mode),
+ except that requesting credentials from user remains disabled for cross-origin requests.
+
+ Patch is covered by http/tests/media/video-auth.html.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.
+
2014-09-16 Jinho Bang <[email protected]>
Add version of drawFocusIfNeeded that take a Path2D parameter.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (173653 => 173654)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-09-16 08:16:36 UTC (rev 173653)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-09-16 08:46:10 UTC (rev 173654)
@@ -996,7 +996,7 @@
{
DataBufferingPolicy bufferingPolicy = request.url().protocolIs("blob") ? BufferData : DoNotBufferData;
RequestOriginPolicy corsPolicy = corsMode != MediaPlayerClient::Unspecified ? PotentiallyCrossOriginEnabled : UseDefaultOriginRestrictionsForType;
- StoredCredentials allowCredentials = corsMode == MediaPlayerClient::UseCredentials ? AllowStoredCredentials : DoNotAllowStoredCredentials;
+ StoredCredentials allowCredentials = corsMode == MediaPlayerClient::Anonymous ? DoNotAllowStoredCredentials : AllowStoredCredentials;
ResourceLoaderOptions options(SendCallbacks, DoNotSniffContent, bufferingPolicy, allowCredentials, DoNotAskClientForCrossOriginCredentials, DoSecurityCheck, corsPolicy, DoNotIncludeCertificateInfo);
CachedResourceRequest cacheRequest(request, options);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
