[webkit-changes] [173656] trunk

Tue, 16 Sep 2014 01:58:56 -0700

Title: [173656] trunk
Revision
173656
Author
[email protected]
Date
2014-09-16 01:58:06 -0700 (Tue, 16 Sep 2014)

Log Message

JSC test gardening
https://bugs.webkit.org/show_bug.cgi?id=136823

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

* tests/mozilla/mozilla-tests.yaml: Unskip passing tests.

Tools:

* Scripts/run-_javascript_core-tests: Skip tests on only the affected platforms.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (173655 => 173656)


--- trunk/Source/_javascript_Core/ChangeLog	2014-09-16 08:57:12 UTC (rev 173655)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-09-16 08:58:06 UTC (rev 173656)
@@ -1,3 +1,12 @@
+2014-09-16  Csaba Osztrogonác  <[email protected]>
+
+        JSC test gardening
+        https://bugs.webkit.org/show_bug.cgi?id=136823
+
+        Reviewed by Geoffrey Garen.
+
+        * tests/mozilla/mozilla-tests.yaml: Unskip passing tests.
+
 2014-09-15  Michael Saboff  <[email protected]>
 
         Create a JSCallee for GlobalExec object

Modified: trunk/Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml (173655 => 173656)


--- trunk/Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml	2014-09-16 08:57:12 UTC (rev 173655)
+++ trunk/Source/_javascript_Core/tests/mozilla/mozilla-tests.yaml	2014-09-16 08:58:06 UTC (rev 173656)
@@ -104,19 +104,19 @@
 - path: ecma/Date/15.9.1.1-2.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.1.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-1.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-2.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-3.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-4.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-5.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.2.2-6.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.3.1-1.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.3.1-2.js
@@ -228,7 +228,7 @@
 - path: ecma/Date/15.9.5.13-8.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.14.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.15.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.16.js
@@ -348,13 +348,13 @@
 - path: ecma/Date/15.9.5.30-1.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.31-1.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.32-1.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.33-1.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.34-1.js
-  cmd: defaultRunMozillaTest :skip, "../shell.js"
+  cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.35-1.js
   cmd: defaultRunMozillaTest :normal, "../shell.js"
 - path: ecma/Date/15.9.5.36-1.js

Modified: trunk/Tools/ChangeLog (173655 => 173656)


--- trunk/Tools/ChangeLog	2014-09-16 08:57:12 UTC (rev 173655)
+++ trunk/Tools/ChangeLog	2014-09-16 08:58:06 UTC (rev 173656)
@@ -1,3 +1,12 @@
+2014-09-16  Csaba Osztrogonác  <[email protected]>
+
+        JSC test gardening
+        https://bugs.webkit.org/show_bug.cgi?id=136823
+
+        Reviewed by Geoffrey Garen.
+
+        * Scripts/run-_javascript_core-tests: Skip tests on only the affected platforms.
+
 2014-09-16  Eva Balazsfalvi  <[email protected]>
 
         Remove shouldAbortEarly cruft from master.cfg

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (173655 => 173656)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2014-09-16 08:57:12 UTC (rev 173655)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2014-09-16 08:58:06 UTC (rev 173656)
@@ -42,7 +42,7 @@
 setConfiguration();
 my $configuration = configuration();
 
-my @testsToSkip = (
+my @testsToSkipOnWindows = (
     # Various ecma/Date tests sometimes fail on Windows (but not Mac) https://bugs.webkit.org/show_bug.cgi?id=25160
     "ecma/Date/15.9.2.1.js",
     "ecma/Date/15.9.2.2-1.js",
@@ -52,12 +52,18 @@
     "ecma/Date/15.9.2.2-5.js",
     "ecma/Date/15.9.2.2-6.js",
     "ecma/Date/15.9.5.31-1.js",
+);
+
+my @testsToSkipOnNonWindows = (
     # ecma_3/Date/15.9.5.7.js fails on Mac (but not Windows) https://bugs.webkit.org/show_bug.cgi?id=25161
-    "ecma_3/Date/15.9.5.6.js",
     "ecma_3/Date/15.9.5.7.js",
 );
 
-my $jsDriverArgs = "-L " . join(" ", @testsToSkip);
+my @testsToSkip;
+@testsToSkip = @testsToSkipOnWindows if isAppleWinWebKit();
+@testsToSkip = (@testsToSkip, @testsToSkipOnNonWindows) if !isAppleWinWebKit();
+my $jsDriverArgs = "-L " . join(" ", @testsToSkip) if @testsToSkip;
+
 # These variables are intentionally left undefined.
 my $root;
 my $showHelp;

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to