Title: [173660] trunk/Source/WebCore
- Revision
- 173660
- Author
- [email protected]
- Date
- 2014-09-16 09:18:59 -0700 (Tue, 16 Sep 2014)
Log Message
URTBF after r173659.
After r173659 convertToIntLength() is used only inside ENABLE(DASHBOARD_SUPPORT), so it
became unused function and caused build failure if ENABLE(DASHBOARD_SUPPORT) is false.
Source/WebCore/css/StyleResolver.cpp:1471:15: error: 'WebCore::Length WebCore::convertToIntLength(const WebCore::CSSPrimitiveValue*, const WebCore::CSSToLengthConversionData&)'
defined but not used [-Werror=unused-function] cc1plus: all warnings being treated as errors
* css/StyleResolver.cpp: Missing ENABLE(DASHBOARD_SUPPORT) guard added.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173659 => 173660)
--- trunk/Source/WebCore/ChangeLog 2014-09-16 15:58:12 UTC (rev 173659)
+++ trunk/Source/WebCore/ChangeLog 2014-09-16 16:18:59 UTC (rev 173660)
@@ -1,3 +1,15 @@
+2014-09-16 Csaba Osztrogonác <[email protected]>
+
+ URTBF after r173659.
+
+ After r173659 convertToIntLength() is used only inside ENABLE(DASHBOARD_SUPPORT), so it
+ became unused function and caused build failure if ENABLE(DASHBOARD_SUPPORT) is false.
+
+ Source/WebCore/css/StyleResolver.cpp:1471:15: error: 'WebCore::Length WebCore::convertToIntLength(const WebCore::CSSPrimitiveValue*, const WebCore::CSSToLengthConversionData&)'
+ defined but not used [-Werror=unused-function] cc1plus: all warnings being treated as errors
+
+ * css/StyleResolver.cpp: Missing ENABLE(DASHBOARD_SUPPORT) guard added.
+
2014-09-14 Darin Adler <[email protected]>
Scroll snap properties don't handle inherit and initial propertly.
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (173659 => 173660)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-16 15:58:12 UTC (rev 173659)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-09-16 16:18:59 UTC (rev 173660)
@@ -1468,10 +1468,12 @@
// -------------------------------------------------------------------------------------
+#if ENABLE(DASHBOARD_SUPPORT)
static Length convertToIntLength(const CSSPrimitiveValue* primitiveValue, const CSSToLengthConversionData& conversionData)
{
return primitiveValue ? primitiveValue->convertToLength<FixedIntegerConversion | PercentConversion | CalculatedConversion>(conversionData) : Length(Undefined);
}
+#endif
static Length convertToFloatLength(const CSSPrimitiveValue* primitiveValue, const CSSToLengthConversionData& conversionData)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
