Title: [173786] trunk/Tools
- Revision
- 173786
- Author
- [email protected]
- Date
- 2014-09-19 19:44:25 -0700 (Fri, 19 Sep 2014)
Log Message
build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
https://bugs.webkit.org/show_bug.cgi?id=136966
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js (173785 => 173786)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-09-20 02:33:44 UTC (rev 173785)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js 2014-09-20 02:44:25 UTC (rev 173786)
@@ -102,7 +102,7 @@
parsedDescription.innerHTML = description;
var location = "";
- if (parsedDescription.firstChild.className === "changes") {
+ if (parsedDescription.firstChild && parsedDescription.firstChild.className === "changes") {
// We can extract branch information when trac.ini contains "changeset_show_files=location".
location = doc.evaluate("//strong", parsedDescription.firstChild, null, XPathResult.STRING_TYPE).stringValue
parsedDescription.removeChild(parsedDescription.firstChild);
@@ -110,7 +110,7 @@
// The feed contains a <title>, but it's not parsed as well as what we are getting from description.
var title = document.createElement("div");
- var node = parsedDescription.firstChild.firstChild;
+ var node = parsedDescription.firstChild ? parsedDescription.firstChild.firstChild : null;
while (node && node.tagName != "BR") {
title.appendChild(node.cloneNode(true));
node = node.nextSibling;
Modified: trunk/Tools/ChangeLog (173785 => 173786)
--- trunk/Tools/ChangeLog 2014-09-20 02:33:44 UTC (rev 173785)
+++ trunk/Tools/ChangeLog 2014-09-20 02:44:25 UTC (rev 173786)
@@ -1,3 +1,13 @@
+2014-09-19 Alexey Proskuryakov <[email protected]>
+
+ build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
+ https://bugs.webkit.org/show_bug.cgi?id=136966
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
+ (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
+
2014-09-19 Gyuyoung Kim <[email protected]>
[CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
