Title: [173802] trunk/Source/WebKit/mac
- Revision
- 173802
- Author
- [email protected]
- Date
- 2014-09-21 17:31:16 -0700 (Sun, 21 Sep 2014)
Log Message
Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
https://bugs.webkit.org/show_bug.cgi?id=136972
Patch by Joseph Pecoraro <[email protected]> on 2014-09-21
Reviewed by Darin Adler.
* WebView/WebNotification.h:
* WebView/WebNotification.mm:
(-[WebNotification initWithCoreNotification:notificationID:]):
Switch to RetainPtr and adopt into _private to ensure when we are
deallocated that _private will get deallocated.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (173801 => 173802)
--- trunk/Source/WebKit/mac/ChangeLog 2014-09-22 00:24:44 UTC (rev 173801)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-09-22 00:31:16 UTC (rev 173802)
@@ -1,3 +1,16 @@
+2014-09-21 Joseph Pecoraro <[email protected]>
+
+ Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
+ https://bugs.webkit.org/show_bug.cgi?id=136972
+
+ Reviewed by Darin Adler.
+
+ * WebView/WebNotification.h:
+ * WebView/WebNotification.mm:
+ (-[WebNotification initWithCoreNotification:notificationID:]):
+ Switch to RetainPtr and adopt into _private to ensure when we are
+ deallocated that _private will get deallocated.
+
2014-09-19 Dean Jackson <[email protected]>
Multithreaded WebGL is a bad idea - remove it
Modified: trunk/Source/WebKit/mac/WebView/WebNotification.h (173801 => 173802)
--- trunk/Source/WebKit/mac/WebView/WebNotification.h 2014-09-22 00:24:44 UTC (rev 173801)
+++ trunk/Source/WebKit/mac/WebView/WebNotification.h 2014-09-22 00:31:16 UTC (rev 173802)
@@ -26,12 +26,14 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#include <wtf/RetainPtr.h>
+
@class WebNotificationPrivate;
@class WebSecurityOrigin;
@interface WebNotification : NSObject
{
- WebNotificationPrivate *_private;
+ RetainPtr<WebNotificationPrivate> _private;
}
- (NSString *)title;
Modified: trunk/Source/WebKit/mac/WebView/WebNotification.mm (173801 => 173802)
--- trunk/Source/WebKit/mac/WebView/WebNotification.mm 2014-09-22 00:24:44 UTC (rev 173801)
+++ trunk/Source/WebKit/mac/WebView/WebNotification.mm 2014-09-22 00:31:16 UTC (rev 173802)
@@ -39,8 +39,6 @@
using namespace WebCore;
#endif
-OBJC_CLASS WebNotificationInternal;
-
@interface WebNotificationPrivate : NSObject
{
@public
@@ -67,7 +65,7 @@
{
if (!(self = [super init]))
return nil;
- _private = [[WebNotificationPrivate alloc] init];
+ _private = adoptNS([[WebNotificationPrivate alloc] init]);
_private->_internal = coreNotification;
_private->_notificationID = notificationID;
return self;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
