Title: [173997] trunk/Tools
- Revision
- 173997
- Author
- [email protected]
- Date
- 2014-09-25 23:24:03 -0700 (Thu, 25 Sep 2014)
Log Message
[EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=136854
Patch by Rohit Kumar <[email protected]> on 2014-09-25
Reviewed by Gyuyoung Kim.
'Escape' key should exit fullscreen first and then should be used to stop page load.
* MiniBrowser/efl/main.c:
(on_key_down):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (173996 => 173997)
--- trunk/Tools/ChangeLog 2014-09-26 06:03:05 UTC (rev 173996)
+++ trunk/Tools/ChangeLog 2014-09-26 06:24:03 UTC (rev 173997)
@@ -1,3 +1,15 @@
+2014-09-25 Rohit Kumar <[email protected]>
+
+ [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=136854
+
+ Reviewed by Gyuyoung Kim.
+
+ 'Escape' key should exit fullscreen first and then should be used to stop page load.
+
+ * MiniBrowser/efl/main.c:
+ (on_key_down):
+
2014-09-25 Dean Jackson <[email protected]>
Add Said to the contributors list so his name completes in bugzilla.
Modified: trunk/Tools/MiniBrowser/efl/main.c (173996 => 173997)
--- trunk/Tools/MiniBrowser/efl/main.c 2014-09-26 06:03:05 UTC (rev 173996)
+++ trunk/Tools/MiniBrowser/efl/main.c 2014-09-26 06:24:03 UTC (rev 173997)
@@ -545,8 +545,8 @@
} else if (!strcmp(ev->key, "F5") || (!strcmp(ev->key, "r") && ctrlPressed)) {
info("Reload (F5 or Ctrl+r) was pressed, reloading...");
ewk_view_reload(ewk_view);
- } else if (!strcmp(ev->key, "F6") || !strcmp(ev->key, "Escape")) {
- info("Stop (F6 or Escape) was pressed, stop loading.");
+ } else if (!strcmp(ev->key, "F6")) {
+ info("Stop (F6) was pressed, stop loading.");
ewk_view_stop(ewk_view);
} else if (!strcmp(ev->key, "F7")) {
Ewk_Pagination_Mode mode = ewk_view_pagination_mode_get(ewk_view);
@@ -578,6 +578,8 @@
history_list_hide(window);
else if (elm_win_fullscreen_get(window->elm_window))
ewk_view_fullscreen_exit(ewk_view);
+ else
+ ewk_view_stop(ewk_view);
} else if (ctrlPressed && (!strcmp(ev->key, "minus") || !strcmp(ev->key, "KP_Subtract"))) {
if (zoom_level_set(ewk_view, window->current_zoom_level - 1))
window->current_zoom_level--;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes