Title: [174007] trunk/Source/WebCore
- Revision
- 174007
- Author
- [email protected]
- Date
- 2014-09-26 07:27:52 -0700 (Fri, 26 Sep 2014)
Log Message
[CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
https://bugs.webkit.org/show_bug.cgi?id=137146
Reviewed by Sergio Villar Senin.
When checking out for white-space only strings in the grid-template-areas
property values, it's not neccessary to check out for empty strings as
such case is already covered.
No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174006 => 174007)
--- trunk/Source/WebCore/ChangeLog 2014-09-26 13:41:57 UTC (rev 174006)
+++ trunk/Source/WebCore/ChangeLog 2014-09-26 14:27:52 UTC (rev 174007)
@@ -1,3 +1,19 @@
+2014-09-26 Javier Fernandez <[email protected]>
+
+ [CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
+ https://bugs.webkit.org/show_bug.cgi?id=137146
+
+ Reviewed by Sergio Villar Senin.
+
+ When checking out for white-space only strings in the grid-template-areas
+ property values, it's not neccessary to check out for empty strings as
+ such case is already covered.
+
+ No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.
+
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseGridTemplateAreasRow):
+
2014-09-23 Sergio Villar Senin <[email protected]>
[CSS Grid Layout] Fix the handling of infinity in track growth limits
Modified: trunk/Source/WebCore/css/CSSParser.cpp (174006 => 174007)
--- trunk/Source/WebCore/css/CSSParser.cpp 2014-09-26 13:41:57 UTC (rev 174006)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2014-09-26 14:27:52 UTC (rev 174007)
@@ -5569,7 +5569,7 @@
return false;
String gridRowNames = currentValue->string;
- if (gridRowNames.isEmpty() || gridRowNames.containsOnlyWhitespace())
+ if (gridRowNames.containsOnlyWhitespace())
return false;
Vector<String> columnNames;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
