Title: [174014] trunk/Source/WebCore
- Revision
- 174014
- Author
- [email protected]
- Date
- 2014-09-26 11:26:29 -0700 (Fri, 26 Sep 2014)
Log Message
StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
https://bugs.webkit.org/show_bug.cgi?id=129642
Apply post-review comments from Alexey Proskuryakov.
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::deleteEmptyDatabase): Make a thread-safe isolated copy of the string.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174013 => 174014)
--- trunk/Source/WebCore/ChangeLog 2014-09-26 17:50:05 UTC (rev 174013)
+++ trunk/Source/WebCore/ChangeLog 2014-09-26 18:26:29 UTC (rev 174014)
@@ -1,3 +1,13 @@
+2014-09-26 Brian J. Burg <[email protected]>
+
+ StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
+ https://bugs.webkit.org/show_bug.cgi?id=129642
+
+ Apply post-review comments from Alexey Proskuryakov.
+
+ * storage/StorageAreaSync.cpp:
+ (WebCore::StorageAreaSync::deleteEmptyDatabase): Make a thread-safe isolated copy of the string.
+
2014-09-26 Myles C. Maxfield <[email protected]>
SVG -> OTF converter bug gardening
Modified: trunk/Source/WebCore/storage/StorageAreaSync.cpp (174013 => 174014)
--- trunk/Source/WebCore/storage/StorageAreaSync.cpp 2014-09-26 17:50:05 UTC (rev 174013)
+++ trunk/Source/WebCore/storage/StorageAreaSync.cpp 2014-09-26 18:26:29 UTC (rev 174014)
@@ -522,8 +522,10 @@
query.finalize();
m_database.close();
if (StorageTracker::tracker().isActive()) {
- callOnMainThread([this] {
- StorageTracker::tracker().deleteOriginWithIdentifier(m_databaseIdentifier);
+ StringImpl* databaseIdentifierCopy = &m_databaseIdentifier.impl()->isolatedCopy().leakRef();
+ callOnMainThread([databaseIdentifierCopy] {
+ StorageTracker::tracker().deleteOriginWithIdentifier(databaseIdentifierCopy);
+ databaseIdentifierCopy->deref();
});
} else {
String databaseFilename = m_syncManager->fullDatabaseFilename(m_databaseIdentifier);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
