Title: [174027] trunk/Tools
- Revision
- 174027
- Author
- [email protected]
- Date
- 2014-09-26 16:18:08 -0700 (Fri, 26 Sep 2014)
Log Message
Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
https://bugs.webkit.org/show_bug.cgi?id=137089
Reviewed by Tim Horton.
This is a little sneaky since updateWindowScaleForTest() should ensure that these
tests run at 1x, but that code does not seem to execute at the right time for
these tests, so if we just ensure we start out at 1x, that appears to fix these
tests and does not break the HiDPI tests either.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (174026 => 174027)
--- trunk/Tools/ChangeLog 2014-09-26 22:54:07 UTC (rev 174026)
+++ trunk/Tools/ChangeLog 2014-09-26 23:18:08 UTC (rev 174027)
@@ -1,3 +1,17 @@
+2014-09-26 Beth Dakin <[email protected]>
+
+ Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
+ https://bugs.webkit.org/show_bug.cgi?id=137089
+
+ Reviewed by Tim Horton.
+
+ This is a little sneaky since updateWindowScaleForTest() should ensure that these
+ tests run at 1x, but that code does not seem to execute at the right time for
+ these tests, so if we just ensure we start out at 1x, that appears to fix these
+ tests and does not break the HiDPI tests either.
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::createWebViewWithOptions):
+
2014-09-26 Roger Fong <[email protected]>
[Windows] Decrease default number of child processes used by Windows.
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (174026 => 174027)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2014-09-26 22:54:07 UTC (rev 174026)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2014-09-26 23:18:08 UTC (rev 174027)
@@ -515,6 +515,10 @@
WKPageSetPagePolicyClient(m_mainWebView->page(), &pagePolicyClient.base);
m_mainWebView->didInitializeClients();
+
+ // Generally, the tests should default to running at 1x. updateWindowScaleForTest() will adjust the scale to
+ // something else for specific tests that need to run at a different window scale.
+ m_mainWebView->changeWindowScaleIfNeeded(1);
}
void TestController::ensureViewSupportsOptions(WKDictionaryRef options)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
