Title: [174124] trunk/Tools
Revision
174124
Author
[email protected]
Date
2014-09-30 14:30:22 -0700 (Tue, 30 Sep 2014)

Log Message

Windows EWS went purple when it failed to build
https://bugs.webkit.org/show_bug.cgi?id=137267

Reviewed by Ryosuke Niwa.

* QueueStatusServer/app.yaml: Update the version.

* QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
Make it work for style and win-ews queues.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174123 => 174124)


--- trunk/Tools/ChangeLog	2014-09-30 21:11:57 UTC (rev 174123)
+++ trunk/Tools/ChangeLog	2014-09-30 21:30:22 UTC (rev 174124)
@@ -1,3 +1,15 @@
+2014-09-30  Alexey Proskuryakov  <[email protected]>
+
+        Windows EWS went purple when it failed to build
+        https://bugs.webkit.org/show_bug.cgi?id=137267
+
+        Reviewed by Ryosuke Niwa.
+
+        * QueueStatusServer/app.yaml: Update the version.
+
+        * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
+        Make it work for style and win-ews queues.
+
 2014-09-29  Filip Pizlo  <[email protected]>
 
         It should be fun and easy to run every possible _javascript_ benchmark from the command line

Modified: trunk/Tools/QueueStatusServer/app.yaml (174123 => 174124)


--- trunk/Tools/QueueStatusServer/app.yaml	2014-09-30 21:11:57 UTC (rev 174123)
+++ trunk/Tools/QueueStatusServer/app.yaml	2014-09-30 21:30:22 UTC (rev 174124)
@@ -1,5 +1,5 @@
 application: webkit-queues
-version: 174115 # Bugzilla bug ID of last major change
+version: 174124 # Bugzilla bug ID of last major change
 runtime: python
 api_version: 1
 

Modified: trunk/Tools/QueueStatusServer/model/attachment.py (174123 => 174124)


--- trunk/Tools/QueueStatusServer/model/attachment.py	2014-09-30 21:11:57 UTC (rev 174123)
+++ trunk/Tools/QueueStatusServer/model/attachment.py	2014-09-30 21:30:22 UTC (rev 174124)
@@ -66,7 +66,9 @@
         return self._cached_queue_positions
 
     def _calculate_queue_positions(self):
-        all_work_items = WorkItems.all().fetch(limit=len(Queue.all()))
+        # We don't know how many rows there are in the table (as there can be stale rows
+        # from queues that we no longer have), but it's certainly fewer that 1000.
+        all_work_items = WorkItems.all().fetch(limit=1000)
         return dict([(items.queue.name(), items.display_position_for_attachment(self.id)) for items in all_work_items if items.queue])
 
     # FIXME: This is controller/view code and does not belong in a model.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to