Title: [174252] trunk/Source/WebCore
- Revision
- 174252
- Author
- [email protected]
- Date
- 2014-10-02 17:37:47 -0700 (Thu, 02 Oct 2014)
Log Message
<rdar://problem/18531395> REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response
https://bugs.webkit.org/show_bug.cgi?id=137239
Reviewed by Pratik Solanki.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformSuggestedFilename): Return the null String if
m_cfResponse is null.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174251 => 174252)
--- trunk/Source/WebCore/ChangeLog 2014-10-03 00:30:42 UTC (rev 174251)
+++ trunk/Source/WebCore/ChangeLog 2014-10-03 00:37:47 UTC (rev 174252)
@@ -1,3 +1,14 @@
+2014-10-02 Dan Bernstein <[email protected]>
+
+ <rdar://problem/18531395> REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response
+ https://bugs.webkit.org/show_bug.cgi?id=137239
+
+ Reviewed by Pratik Solanki.
+
+ * platform/network/cf/ResourceResponseCFNet.cpp:
+ (WebCore::ResourceResponse::platformSuggestedFilename): Return the null String if
+ m_cfResponse is null.
+
2014-10-02 Andy Estes <[email protected]>
[iOS] Create an SPI wrapper for _UIHighlightView and use it in WKContentView
Modified: trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp (174251 => 174252)
--- trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp 2014-10-03 00:30:42 UTC (rev 174251)
+++ trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp 2014-10-03 00:37:47 UTC (rev 174252)
@@ -127,6 +127,9 @@
String ResourceResponse::platformSuggestedFilename() const
{
+ if (!m_cfResponse)
+ return String();
+
RetainPtr<CFStringRef> suggestedFilename = adoptCF(CFURLResponseCopySuggestedFilename(m_cfResponse.get()));
return suggestedFilename.get();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
