Title: [174311] trunk/Source/WebCore
Revision
174311
Author
[email protected]
Date
2014-10-04 00:56:23 -0700 (Sat, 04 Oct 2014)

Log Message

[TexMap] Clean up GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=137263

Reviewed by Darin Adler.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded): Clean up
the method a bit. When the backing store will not be in use the change mask
should only get updated if there was a backing store present beforehand.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (174310 => 174311)


--- trunk/Source/WebCore/ChangeLog	2014-10-04 07:46:42 UTC (rev 174310)
+++ trunk/Source/WebCore/ChangeLog	2014-10-04 07:56:23 UTC (rev 174311)
@@ -1,5 +1,17 @@
 2014-10-04  Zan Dobersek  <[email protected]>
 
+        [TexMap] Clean up GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded()
+        https://bugs.webkit.org/show_bug.cgi?id=137263
+
+        Reviewed by Darin Adler.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded): Clean up
+        the method a bit. When the backing store will not be in use the change mask
+        should only get updated if there was a backing store present beforehand.
+
+2014-10-04  Zan Dobersek  <[email protected]>
+
         [TexMap] Remove QDoc comments in GraphicsLayerTextureMapper
         https://bugs.webkit.org/show_bug.cgi?id=137264
 

Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (174310 => 174311)


--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2014-10-04 07:46:42 UTC (rev 174310)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp	2014-10-04 07:56:23 UTC (rev 174311)
@@ -389,14 +389,16 @@
 
 void GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded()
 {
-    if (!shouldHaveBackingStore()) {
-        m_backingStore.clear();
-        m_changeMask |= BackingStoreChange;
-    } else {
+    if (shouldHaveBackingStore()) {
         if (!m_backingStore) {
             m_backingStore = TextureMapperTiledBackingStore::create();
             m_changeMask |= BackingStoreChange;
         }
+    } else {
+        if (m_backingStore) {
+            m_backingStore = nullptr;
+            m_changeMask |= BackingStoreChange;
+        }
     }
 
     updateDebugBorderAndRepaintCount();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to