Title: [174343] trunk/Tools
Revision
174343
Author
[email protected]
Date
2014-10-06 07:34:59 -0700 (Mon, 06 Oct 2014)

Log Message

EWS bubble hover shows wrong timestamps
https://bugs.webkit.org/show_bug.cgi?id=137252

Reviewed by Alexey Proskuryakov.

Add "Z" suffix to timestamps to make sure if it is handled as UTC time.

* QueueStatusServer/handlers/queuestatusjson.py:
(QueueStatusJSON.get):
* QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._iso_time):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174342 => 174343)


--- trunk/Tools/ChangeLog	2014-10-06 12:47:26 UTC (rev 174342)
+++ trunk/Tools/ChangeLog	2014-10-06 14:34:59 UTC (rev 174343)
@@ -1,3 +1,17 @@
+2014-10-06  Csaba Osztrogonác  <[email protected]>
+
+        EWS bubble hover shows wrong timestamps
+        https://bugs.webkit.org/show_bug.cgi?id=137252
+
+        Reviewed by Alexey Proskuryakov.
+
+        Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
+
+        * QueueStatusServer/handlers/queuestatusjson.py:
+        (QueueStatusJSON.get):
+        * QueueStatusServer/handlers/statusbubble.py:
+        (StatusBubble._iso_time):
+
 2014-10-06  Mario Sanchez Prada  <[email protected]>
 
         Unreviewed, updated list of email addresses in contributors.json

Modified: trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py (174342 => 174343)


--- trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py	2014-10-06 12:47:26 UTC (rev 174342)
+++ trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py	2014-10-06 14:34:59 UTC (rev 174343)
@@ -116,5 +116,5 @@
             "queue": self._rows_for_work_items(queue),
             "bots": self._bots(queue),
         }
-        dthandler = lambda obj: obj.isoformat() if isinstance(obj, datetime.datetime) or isinstance(obj, datetime.date) else None
+        dthandler = lambda obj: obj.isoformat() + "Z" if isinstance(obj, datetime.datetime) or isinstance(obj, datetime.date) else None
         self.response.out.write(json.dumps(status, default=dthandler))

Modified: trunk/Tools/QueueStatusServer/handlers/statusbubble.py (174342 => 174343)


--- trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2014-10-06 12:47:26 UTC (rev 174342)
+++ trunk/Tools/QueueStatusServer/handlers/statusbubble.py	2014-10-06 14:34:59 UTC (rev 174343)
@@ -56,7 +56,7 @@
 
 class StatusBubble(webapp.RequestHandler):
     def _iso_time(self, time):
-        return "[[" + time.isoformat() + "]]"
+        return "[[" + time.isoformat() + "Z]]"
 
     # queue_position includes items that are already active, so it's misleading.
     # For a queue that has 8 bots, being #9 in the queue actually means being #1.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to