Title: [174376] trunk/Tools
- Revision
- 174376
- Author
- [email protected]
- Date
- 2014-10-06 18:10:04 -0700 (Mon, 06 Oct 2014)
Log Message
AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
https://bugs.webkit.org/show_bug.cgi?id=137289
Unreviewed build fix.
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::getChildrenWithRange):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (174375 => 174376)
--- trunk/Tools/ChangeLog 2014-10-07 00:26:25 UTC (rev 174375)
+++ trunk/Tools/ChangeLog 2014-10-07 01:10:04 UTC (rev 174376)
@@ -1,3 +1,13 @@
+2014-10-06 Chris Fleizach <[email protected]>
+
+ AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
+ https://bugs.webkit.org/show_bug.cgi?id=137289
+
+ Unreviewed build fix.
+
+ * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
+ (AccessibilityUIElement::getChildrenWithRange):
+
2014-10-06 Alexey Proskuryakov <[email protected]>
build.webkit.org/dashboard: Add commit queue
Modified: trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm (174375 => 174376)
--- trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm 2014-10-07 00:26:25 UTC (rev 174375)
+++ trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm 2014-10-07 01:10:04 UTC (rev 174376)
@@ -191,7 +191,10 @@
void AccessibilityUIElement::getChildrenWithRange(Vector<AccessibilityUIElement>& elementVector, unsigned location, unsigned length)
{
- for (NSInteger k = location; k < (location+length); ++k)
+ // accessibilityElementAtIndex: takes an NSInteger.
+ // We want to preserve that in order to test against invalid indexes being input.
+ NSInteger maxValue = static_cast<NSInteger>(location + length);
+ for (NSInteger k = location; k < maxValue; ++k)
elementVector.append(AccessibilityUIElement([m_element accessibilityElementAtIndex:k]));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
