Title: [174385] trunk/Tools
Revision
174385
Author
[email protected]
Date
2014-10-06 22:26:20 -0700 (Mon, 06 Oct 2014)

Log Message

Make webkit-patch find-users useful
https://bugs.webkit.org/show_bug.cgi?id=137475

Reviewed by Alexey Proskuryakov.

Make find-users use the CommitterList instead of accessing Bugzilla.

This essentially exposes the same functionality as webkitbot's whois command.

* Scripts/webkitpy/tool/commands/findusers.py:
(FindUsers.execute):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174384 => 174385)


--- trunk/Tools/ChangeLog	2014-10-07 04:42:01 UTC (rev 174384)
+++ trunk/Tools/ChangeLog	2014-10-07 05:26:20 UTC (rev 174385)
@@ -1,3 +1,17 @@
+2014-10-06  Ryosuke Niwa  <[email protected]>
+
+        Make webkit-patch find-users useful
+        https://bugs.webkit.org/show_bug.cgi?id=137475
+
+        Reviewed by Alexey Proskuryakov.
+
+        Make find-users use the CommitterList instead of accessing Bugzilla.
+
+        This essentially exposes the same functionality as webkitbot's whois command.
+
+        * Scripts/webkitpy/tool/commands/findusers.py:
+        (FindUsers.execute):
+
 2014-10-06  Chris Fleizach  <[email protected]>
 
         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py (174384 => 174385)


--- trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py	2014-10-07 04:42:01 UTC (rev 174384)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py	2014-10-07 05:26:20 UTC (rev 174385)
@@ -1,4 +1,5 @@
 # Copyright (c) 2011 Google Inc. All rights reserved.
+# Copyright (c) 2014 Apple Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
@@ -27,6 +28,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 from webkitpy.tool.multicommandtool import Command
+from webkitpy.common.config.committers import CommitterList
 
 
 class FindUsers(Command):
@@ -35,10 +37,6 @@
 
     def execute(self, options, args, tool):
         search_string = args[0]
-        login_userid_pairs = tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
-        for (login, user_id) in login_userid_pairs:
-            user = tool.bugs.fetch_user(user_id)
-            groups_string = ", ".join(user['groups']) if user['groups'] else "none"
-            print "%s <%s> (%s) (%s)" % (user['name'], user['login'], user_id, groups_string)
-        else:
-            print "No users found matching '%s'" % search_string
+        users = CommitterList().contributors_by_search_string(search_string)
+        for user in users:
+            print user
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to