Title: [174486] trunk/Websites/perf.webkit.org
- Revision
- 174486
- Author
- [email protected]
- Date
- 2014-10-08 17:19:14 -0700 (Wed, 08 Oct 2014)
Log Message
Unreviewed build fix after r174477.
* init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
Also fixed a syntax error that we were missing "," after line that declared build_commit column.
* public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
This is necessary for baseline and target values manually added via admin pages.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (174485 => 174486)
--- trunk/Websites/perf.webkit.org/ChangeLog 2014-10-09 00:12:55 UTC (rev 174485)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-10-09 00:19:14 UTC (rev 174486)
@@ -1,5 +1,15 @@
2014-10-08 Ryosuke Niwa <[email protected]>
+ Unreviewed build fix after r174477.
+
+ * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
+ Also fixed a syntax error that we were missing "," after line that declared build_commit column.
+
+ * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
+ This is necessary for baseline and target values manually added via admin pages.
+
+2014-10-08 Ryosuke Niwa <[email protected]>
+
Add v2 UI for the perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=137537
Modified: trunk/Websites/perf.webkit.org/init-database.sql (174485 => 174486)
--- trunk/Websites/perf.webkit.org/init-database.sql 2014-10-09 00:12:55 UTC (rev 174485)
+++ trunk/Websites/perf.webkit.org/init-database.sql 2014-10-09 00:19:14 UTC (rev 174486)
@@ -68,9 +68,8 @@
CREATE TABLE build_commits (
commit_build integer NOT NULL REFERENCES builds ON DELETE CASCADE,
- build_commit integer NOT NULL REFERENCES commits ON DELETE CASCADE
+ build_commit integer NOT NULL REFERENCES commits ON DELETE CASCADE,
PRIMARY KEY (commit_build, build_commit));
-CREATE INDEX build_commits_index ON build_commits(commit_build, build_commit);
CREATE TABLE aggregators (
aggregator_id serial PRIMARY KEY,
Modified: trunk/Websites/perf.webkit.org/public/api/runs.php (174485 => 174486)
--- trunk/Websites/perf.webkit.org/public/api/runs.php 2014-10-09 00:12:55 UTC (rev 174485)
+++ trunk/Websites/perf.webkit.org/public/api/runs.php 2014-10-09 00:19:14 UTC (rev 174486)
@@ -31,8 +31,8 @@
function fetch_runs_for_config($db, $config) {
$raw_runs = $db->query_and_fetch_all('
SELECT test_runs.*, builds.*, array_agg((commit_repository, commit_revision, commit_time)) AS revisions
- FROM builds LEFT OUTER JOIN build_commits ON commit_build = build_id, test_runs, commits
- WHERE run_build = build_id AND run_config = $1 AND build_commit = commit_id
+ FROM builds LEFT OUTER JOIN build_commits ON commit_build = build_id LEFT OUTER JOIN commits ON build_commit = commit_id, test_runs
+ WHERE run_build = build_id AND run_config = $1
GROUP BY build_id, run_id', array($config['config_id']));
$formatted_runs = array();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
