Title: [174559] trunk/Source/_javascript_Core
Revision
174559
Author
[email protected]
Date
2014-10-09 22:53:51 -0700 (Thu, 09 Oct 2014)

Log Message

Web Inspector: Remove unused generator code
https://bugs.webkit.org/show_bug.cgi?id=137564

Patch by Joseph Pecoraro <[email protected]> on 2014-10-09
Reviewed by Brian Burg.

* inspector/scripts/codegen/generate_backend_dispatcher_header.py:
(BackendDispatcherHeaderGenerator.generate_output): Deleted.
* inspector/scripts/codegen/generate_backend_dispatcher_implementation.py:
(BackendDispatcherImplementationGenerator.generate_output):
* inspector/scripts/codegen/generate_frontend_dispatcher_header.py:
(FrontendDispatcherHeaderGenerator.generate_output):
* inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py:
(FrontendDispatcherImplementationGenerator.generate_output):
* inspector/scripts/codegen/generate_protocol_types_header.py:
(ProtocolTypesHeaderGenerator.generate_output):
* inspector/scripts/codegen/generate_protocol_types_implementation.py:
(ProtocolTypesImplementationGenerator.generate_output):
inputFilename is now handled by the generic generator base class.

* inspector/scripts/codegen/models.py:
(Framework.fromString):
(Frameworks):
* inspector/scripts/generate-inspector-protocol-bindings.py:
The WTF framework is unused. Remove unexpected frameworks.

Modified Paths

Property Changed

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (174558 => 174559)


--- trunk/Source/_javascript_Core/ChangeLog	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-10-10 05:53:51 UTC (rev 174559)
@@ -1,3 +1,30 @@
+2014-10-09  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Remove unused generator code
+        https://bugs.webkit.org/show_bug.cgi?id=137564
+
+        Reviewed by Brian Burg.
+
+        * inspector/scripts/codegen/generate_backend_dispatcher_header.py:
+        (BackendDispatcherHeaderGenerator.generate_output): Deleted.
+        * inspector/scripts/codegen/generate_backend_dispatcher_implementation.py:
+        (BackendDispatcherImplementationGenerator.generate_output):
+        * inspector/scripts/codegen/generate_frontend_dispatcher_header.py:
+        (FrontendDispatcherHeaderGenerator.generate_output):
+        * inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py:
+        (FrontendDispatcherImplementationGenerator.generate_output):
+        * inspector/scripts/codegen/generate_protocol_types_header.py:
+        (ProtocolTypesHeaderGenerator.generate_output):
+        * inspector/scripts/codegen/generate_protocol_types_implementation.py:
+        (ProtocolTypesImplementationGenerator.generate_output):
+        inputFilename is now handled by the generic generator base class.
+
+        * inspector/scripts/codegen/models.py:
+        (Framework.fromString):
+        (Frameworks):
+        * inspector/scripts/generate-inspector-protocol-bindings.py:
+        The WTF framework is unused. Remove unexpected frameworks.
+
 2014-10-09  Dean Jackson  <[email protected]>
 
         Remove ENABLE_CSS3_CONDITIONAL_RULES

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_header.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_header.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_header.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -60,7 +60,6 @@
             'headerGuardString': re.sub('\W+', '_', self.output_filename()),
             'includes': '\n'.join(['#include ' + header for header in headers]),
             'typedefs': '\n'.join(['typedef %s %s;' % typedef for typedef in typedefs]),
-            'inputFilename': self._input_filepath
         }
 
         sections = []
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_header.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -55,7 +55,6 @@
         header_args = {
             'primaryInclude': '"Inspector%sBackendDispatchers.h"' % self.model().framework.setting('prefix'),
             'secondaryIncludes': "\n".join(['#include %s' % header for header in secondary_headers]),
-            'inputFilename': self._input_filepath
         }
 
         sections = []
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_header.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_header.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_header.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -59,7 +59,6 @@
             'headerGuardString': re.sub('\W+', '_', self.output_filename()),
             'includes': '\n'.join(['#include ' + header for header in headers]),
             'typedefs': '',
-            'inputFilename': self._input_filepath
         }
 
         sections = []
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_header.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -52,7 +52,6 @@
         header_args = {
             'primaryInclude': '"Inspector%sFrontendDispatchers.h"' % self.model().framework.setting('prefix'),
             'secondaryIncludes': "\n".join(['#include %s' % header for header in secondary_headers]),
-            'inputFilename': self._input_filepath
         }
 
         sections = []
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_header.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_header.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_header.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -64,7 +64,6 @@
             'headerGuardString': re.sub('\W+', '_', self.output_filename()),
             'includes': '\n'.join(['#include ' + header for header in sorted(headers)]),
             'typedefs': '',
-            'inputFilename': self._input_filepath
         }
 
         return_type = 'String'
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_header.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_implementation.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_implementation.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_implementation.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -52,7 +52,6 @@
         header_args = {
             'primaryInclude': '"Inspector%sProtocolTypes.h"' % self.model().framework.setting('prefix'),
             'secondaryIncludes': "\n".join(['#include %s' % header for header in secondary_headers]),
-            'inputFilename': self._input_filepath
         }
 
         sections = []
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_protocol_types_implementation.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -37,10 +37,6 @@
     "Global": {
         "prefix": "",
     },
-
-    "WTF": {
-        "prefix": "WTF",
-    },
     "_javascript_Core": {
         "prefix": "JS",
         "export_macro": "JS_EXPORT_PRIVATE"
@@ -76,9 +72,6 @@
         if frameworkString == "Global":
             return Frameworks.Global
 
-        if frameworkString == "WTF":
-            return Frameworks.WTF
-
         if frameworkString == "_javascript_Core":
             return Frameworks._javascript_Core
 
@@ -93,7 +86,6 @@
 
 class Frameworks:
     Global = Framework("Global")
-    WTF = Framework("WTF")
     _javascript_Core = Framework("_javascript_Core")
     WebCore = Framework("WebCore")
     Test = Framework("Test")
Property changes on: trunk/Source/_javascript_Core/inspector/scripts/codegen/models.py
___________________________________________________________________

Added: svn:executable

Modified: trunk/Source/_javascript_Core/inspector/scripts/generate-inspector-protocol-bindings.py (174558 => 174559)


--- trunk/Source/_javascript_Core/inspector/scripts/generate-inspector-protocol-bindings.py	2014-10-10 04:21:57 UTC (rev 174558)
+++ trunk/Source/_javascript_Core/inspector/scripts/generate-inspector-protocol-bindings.py	2014-10-10 05:53:51 UTC (rev 174559)
@@ -148,7 +148,7 @@
 
 
 if __name__ == '__main__':
-    allowed_framework_names = ['WTF', '_javascript_Core', 'WebCore', 'WebKit', 'WebKit2', 'Test']
+    allowed_framework_names = ['_javascript_Core', 'WebCore', 'Test']
     cli_parser = optparse.OptionParser(usage="usage: %prog [options] PrimaryProtocol.json [SupplementalProtocol.json ...]")
     cli_parser.add_option("-o", "--outputDir", help="Directory where generated files should be written.")
     cli_parser.add_option("--framework", type="choice", choices=allowed_framework_names, help="The framework that the primary specification belongs to.")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to