Diff
Modified: trunk/Source/WebCore/ChangeLog (174667 => 174668)
--- trunk/Source/WebCore/ChangeLog 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebCore/ChangeLog 2014-10-14 01:30:03 UTC (rev 174668)
@@ -1,3 +1,28 @@
+2014-10-13 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused stale Page protocol methods
+ https://bugs.webkit.org/show_bug.cgi?id=137678
+
+ Reviewed by Andreas Kling.
+
+ * inspector/InspectorClient.h:
+ (WebCore::InspectorClient::canShowDebugBorders): Deleted.
+ (WebCore::InspectorClient::setShowDebugBorders): Deleted.
+ (WebCore::InspectorClient::canShowFPSCounter): Deleted.
+ (WebCore::InspectorClient::setShowFPSCounter): Deleted.
+ (WebCore::InspectorClient::canContinuouslyPaint): Deleted.
+ (WebCore::InspectorClient::setContinuousPaintingEnabled): Deleted.
+ * inspector/InspectorPageAgent.cpp:
+ (WebCore::InspectorPageAgent::disable):
+ (WebCore::InspectorPageAgent::canShowDebugBorders): Deleted.
+ (WebCore::InspectorPageAgent::setShowDebugBorders): Deleted.
+ (WebCore::InspectorPageAgent::canShowFPSCounter): Deleted.
+ (WebCore::InspectorPageAgent::setShowFPSCounter): Deleted.
+ (WebCore::InspectorPageAgent::canContinuouslyPaint): Deleted.
+ (WebCore::InspectorPageAgent::setContinuousPaintingEnabled): Deleted.
+ * inspector/InspectorPageAgent.h:
+ * inspector/protocol/Page.json:
+
2014-10-13 Eric Carlson <[email protected]>
[iOS] Refactor AirPlay monitoring code
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (174667 => 174668)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2014-10-14 01:30:03 UTC (rev 174668)
@@ -64,16 +64,6 @@
virtual bool overridesShowPaintRects() const { return false; }
virtual void setShowPaintRects(bool) { }
virtual void showPaintRect(const FloatRect&) { }
-
- virtual bool canShowDebugBorders() { return false; }
- virtual void setShowDebugBorders(bool) { }
-
- virtual bool canShowFPSCounter() { return false; }
- virtual void setShowFPSCounter(bool) { }
-
- virtual bool canContinuouslyPaint() { return false; }
- virtual void setContinuousPaintingEnabled(bool) { }
-
virtual void didSetSearchingForNode(bool) { }
virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (174667 => 174668)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp 2014-10-14 01:30:03 UTC (rev 174668)
@@ -379,10 +379,7 @@
ErrorString unused;
setScriptExecutionDisabled(unused, m_originalScriptExecutionDisabled);
setShowPaintRects(unused, false);
- setShowDebugBorders(unused, false);
- setShowFPSCounter(unused, false);
setEmulatedMedia(unused, emptyString());
- setContinuousPaintingEnabled(unused, false);
}
void InspectorPageAgent::addScriptToEvaluateOnLoad(ErrorString&, const String& source, String* identifier)
@@ -660,44 +657,6 @@
m_overlay->setShowingPaintRects(show);
}
-void InspectorPageAgent::canShowDebugBorders(ErrorString&, bool* outParam)
-{
- *outParam = m_client->canShowDebugBorders();
-}
-
-void InspectorPageAgent::setShowDebugBorders(ErrorString&, bool show)
-{
- m_client->setShowDebugBorders(show);
- if (mainFrame() && mainFrame()->view())
- mainFrame()->view()->invalidate();
-}
-
-void InspectorPageAgent::canShowFPSCounter(ErrorString&, bool* outParam)
-{
- *outParam = m_client->canShowFPSCounter();
-}
-
-void InspectorPageAgent::setShowFPSCounter(ErrorString&, bool show)
-{
- m_client->setShowFPSCounter(show);
-
- if (mainFrame() && mainFrame()->view())
- mainFrame()->view()->invalidate();
-}
-
-void InspectorPageAgent::canContinuouslyPaint(ErrorString&, bool* outParam)
-{
- *outParam = m_client->canContinuouslyPaint();
-}
-
-void InspectorPageAgent::setContinuousPaintingEnabled(ErrorString&, bool enabled)
-{
- m_client->setContinuousPaintingEnabled(enabled);
-
- if (!enabled && mainFrame() && mainFrame()->view())
- mainFrame()->view()->invalidate();
-}
-
void InspectorPageAgent::getScriptExecutionStatus(ErrorString&, InspectorPageBackendDispatcherHandler::Result* status)
{
bool disabledByScriptController = false;
Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.h (174667 => 174668)
--- trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.h 2014-10-14 01:30:03 UTC (rev 174668)
@@ -109,12 +109,6 @@
virtual void searchInResources(ErrorString&, const String&, const bool* caseSensitive, const bool* isRegex, RefPtr<Inspector::Protocol::Array<Inspector::Protocol::Page::SearchResult>>&) override;
virtual void setDocumentContent(ErrorString&, const String& frameId, const String& html) override;
virtual void setShowPaintRects(ErrorString&, bool show) override;
- virtual void canShowDebugBorders(ErrorString&, bool*) override;
- virtual void setShowDebugBorders(ErrorString&, bool show) override;
- virtual void canShowFPSCounter(ErrorString&, bool*) override;
- virtual void setShowFPSCounter(ErrorString&, bool show) override;
- virtual void canContinuouslyPaint(ErrorString&, bool*) override;
- virtual void setContinuousPaintingEnabled(ErrorString&, bool enabled) override;
virtual void getScriptExecutionStatus(ErrorString&, Inspector::InspectorPageBackendDispatcherHandler::Result*) override;
virtual void setScriptExecutionDisabled(ErrorString&, bool) override;
virtual void setTouchEmulationEnabled(ErrorString&, bool) override;
Modified: trunk/Source/WebCore/inspector/protocol/Page.json (174667 => 174668)
--- trunk/Source/WebCore/inspector/protocol/Page.json 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebCore/inspector/protocol/Page.json 2014-10-14 01:30:03 UTC (rev 174668)
@@ -197,48 +197,6 @@
]
},
{
- "name": "canShowDebugBorders",
- "description": "Tells if backend supports debug borders on layers",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the debug borders can be shown" }
- ]
- },
- {
- "name": "setShowDebugBorders",
- "description": "Requests that backend shows debug borders on layers",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing debug borders" }
- ]
- },
- {
- "name": "canShowFPSCounter",
- "description": "Tells if backend supports a FPS counter display",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the FPS count can be shown" }
- ]
- },
- {
- "name": "setShowFPSCounter",
- "description": "Requests that backend shows the FPS counter",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing the FPS counter" }
- ]
- },
- {
- "name": "canContinuouslyPaint",
- "description": "Tells if backend supports continuous painting",
- "returns": [
- { "name": "value", "type": "boolean", "description": "True if continuous painting is available" }
- ]
- },
- {
- "name": "setContinuousPaintingEnabled",
- "description": "Requests that backend enables continuous painting",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "True for enabling cointinuous painting" }
- ]
- },
- {
"name": "getScriptExecutionStatus",
"description": "Determines if scripts can be executed in the page.",
"returns": [
Modified: trunk/Source/WebInspectorUI/ChangeLog (174667 => 174668)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-10-14 01:30:03 UTC (rev 174668)
@@ -1,3 +1,15 @@
+2014-10-13 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Improve appearance of alpha color swatches
+ https://bugs.webkit.org/show_bug.cgi?id=137627
+
+ Reviewed by Andreas Kling.
+
+ * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+ * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
+ * Versions/Inspector-iOS-7.0.json:
+ * Versions/InspectorWeb-iOS-8.0.json:
+
2014-10-10 Joseph Pecoraro <[email protected]>
Web Inspector: Improve appearance of alpha color swatches
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (174667 => 174668)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js 2014-10-14 01:30:03 UTC (rev 174668)
@@ -65,12 +65,6 @@
InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canShowDebugBorders", [], ["show"]);
-InspectorBackend.registerCommand("Page.setShowDebugBorders", [{"name": "show", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canShowFPSCounter", [], ["show"]);
-InspectorBackend.registerCommand("Page.setShowFPSCounter", [{"name": "show", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canContinuouslyPaint", [], ["value"]);
-InspectorBackend.registerCommand("Page.setContinuousPaintingEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js (174667 => 174668)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js 2014-10-14 01:30:03 UTC (rev 174668)
@@ -228,12 +228,6 @@
InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canShowDebugBorders", [], ["show"]);
-InspectorBackend.registerCommand("Page.setShowDebugBorders", [{"name": "show", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canShowFPSCounter", [], ["show"]);
-InspectorBackend.registerCommand("Page.setShowFPSCounter", [{"name": "show", "type": "boolean", "optional": false}], []);
-InspectorBackend.registerCommand("Page.canContinuouslyPaint", [], ["value"]);
-InspectorBackend.registerCommand("Page.setContinuousPaintingEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (174667 => 174668)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json 2014-10-14 01:30:03 UTC (rev 174668)
@@ -244,48 +244,6 @@
]
},
{
- "name": "canShowDebugBorders",
- "description": "Tells if backend supports debug borders on layers",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the debug borders can be shown" }
- ]
- },
- {
- "name": "setShowDebugBorders",
- "description": "Requests that backend shows debug borders on layers",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing debug borders" }
- ]
- },
- {
- "name": "canShowFPSCounter",
- "description": "Tells if backend supports a FPS counter display",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the FPS count can be shown" }
- ]
- },
- {
- "name": "setShowFPSCounter",
- "description": "Requests that backend shows the FPS counter",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing the FPS counter" }
- ]
- },
- {
- "name": "canContinuouslyPaint",
- "description": "Tells if backend supports continuous painting",
- "returns": [
- { "name": "value", "type": "boolean", "description": "True if continuous painting is available" }
- ]
- },
- {
- "name": "setContinuousPaintingEnabled",
- "description": "Requests that backend enables continuous painting",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "True for enabling cointinuous painting" }
- ]
- },
- {
"name": "getScriptExecutionStatus",
"description": "Determines if scripts can be executed in the page.",
"returns": [
Modified: trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json (174667 => 174668)
--- trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json 2014-10-14 01:16:25 UTC (rev 174667)
+++ trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json 2014-10-14 01:30:03 UTC (rev 174668)
@@ -2073,48 +2073,6 @@
]
},
{
- "name": "canShowDebugBorders",
- "description": "Tells if backend supports debug borders on layers",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the debug borders can be shown" }
- ]
- },
- {
- "name": "setShowDebugBorders",
- "description": "Requests that backend shows debug borders on layers",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing debug borders" }
- ]
- },
- {
- "name": "canShowFPSCounter",
- "description": "Tells if backend supports a FPS counter display",
- "returns": [
- { "name": "show", "type": "boolean", "description": "True if the FPS count can be shown" }
- ]
- },
- {
- "name": "setShowFPSCounter",
- "description": "Requests that backend shows the FPS counter",
- "parameters": [
- { "name": "show", "type": "boolean", "description": "True for showing the FPS counter" }
- ]
- },
- {
- "name": "canContinuouslyPaint",
- "description": "Tells if backend supports continuous painting",
- "returns": [
- { "name": "value", "type": "boolean", "description": "True if continuous painting is available" }
- ]
- },
- {
- "name": "setContinuousPaintingEnabled",
- "description": "Requests that backend enables continuous painting",
- "parameters": [
- { "name": "enabled", "type": "boolean", "description": "True for enabling cointinuous painting" }
- ]
- },
- {
"name": "getScriptExecutionStatus",
"description": "Determines if scripts can be executed in the page.",
"returns": [
