Title: [174691] trunk/Source/WebCore
- Revision
- 174691
- Author
- [email protected]
- Date
- 2014-10-14 11:32:01 -0700 (Tue, 14 Oct 2014)
Log Message
Remove unnecessary logging from SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=137699
Reviewed by Andreas Kling.
Because of web fonts, fonts that don't have a glyph page 0 are common and expected. Printing out a
message is not helpful, especially if you're not dealing with a font-related piece of WebKit.
No new tests because there is no behavior change.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174690 => 174691)
--- trunk/Source/WebCore/ChangeLog 2014-10-14 18:24:51 UTC (rev 174690)
+++ trunk/Source/WebCore/ChangeLog 2014-10-14 18:32:01 UTC (rev 174691)
@@ -1,3 +1,18 @@
+2014-10-14 Myles C. Maxfield <[email protected]>
+
+ Remove unnecessary logging from SimpleFontData
+ https://bugs.webkit.org/show_bug.cgi?id=137699
+
+ Reviewed by Andreas Kling.
+
+ Because of web fonts, fonts that don't have a glyph page 0 are common and expected. Printing out a
+ message is not helpful, especially if you're not dealing with a font-related piece of WebKit.
+
+ No new tests because there is no behavior change.
+
+ * platform/graphics/SimpleFontData.cpp:
+ (WebCore::SimpleFontData::platformGlyphInit):
+
2014-10-14 Martin Hock <[email protected]>
Update ViewportConfiguration whenever its size attributes change
Modified: trunk/Source/WebCore/platform/graphics/SimpleFontData.cpp (174690 => 174691)
--- trunk/Source/WebCore/platform/graphics/SimpleFontData.cpp 2014-10-14 18:24:51 UTC (rev 174690)
+++ trunk/Source/WebCore/platform/graphics/SimpleFontData.cpp 2014-10-14 18:32:01 UTC (rev 174691)
@@ -115,7 +115,6 @@
{
GlyphPage* glyphPageZero = GlyphPageTreeNode::getRootChild(this, 0)->page();
if (!glyphPageZero) {
- LOG_ERROR("Failed to get glyph page zero.");
m_spaceGlyph = 0;
m_spaceWidth = 0;
m_zeroGlyph = 0;
@@ -127,6 +126,8 @@
return;
}
+ // Ask for the glyph for 0 to avoid paging in ZERO WIDTH SPACE. Control characters, including 0,
+ // are mapped to the ZERO WIDTH SPACE glyph.
m_zeroWidthSpaceGlyph = glyphPageZero->glyphDataForCharacter(0).glyph;
// Nasty hack to determine if we should round or ceil space widths.
@@ -142,13 +143,9 @@
// Force the glyph for ZERO WIDTH SPACE to have zero width, unless it is shared with SPACE.
// Helvetica is an example of a non-zero width ZERO WIDTH SPACE glyph.
- // See <http://bugs.webkit.org/show_bug.cgi?id=13178>
- // Ask for the glyph for 0 to avoid paging in ZERO WIDTH SPACE. Control characters, including 0,
- // are mapped to the ZERO WIDTH SPACE glyph.
- if (m_zeroWidthSpaceGlyph == m_spaceGlyph) {
+ // See <http://bugs.webkit.org/show_bug.cgi?id=13178> and SimpleFontData::isZeroWidthSpaceGlyph()
+ if (m_zeroWidthSpaceGlyph == m_spaceGlyph)
m_zeroWidthSpaceGlyph = 0;
- LOG_ERROR("Font maps SPACE and ZERO WIDTH SPACE to the same glyph. Glyph width will not be overridden.");
- }
m_missingGlyphData.fontData = this;
m_missingGlyphData.glyph = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
