[webkit-changes] [174696] trunk/Source/WebInspectorUI

Tue, 14 Oct 2014 12:29:59 -0700

Title: [174696] trunk/Source/WebInspectorUI
Revision
174696
Author
[email protected]
Date
2014-10-14 12:29:41 -0700 (Tue, 14 Oct 2014)

Log Message

Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
https://bugs.webkit.org/show_bug.cgi?id=137575

Patch by Joseph Pecoraro <[email protected]> on 2014-10-14
Reviewed by Simon Fraser.

Remove setShowPaintRects from the legacy iOS protocol definitions.
The methods were unimplemented by the backends, so they should
not advertise supporting it.

* UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:
* Versions/InspectorWeb-iOS-8.0.json:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (174695 => 174696)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-10-14 19:29:41 UTC (rev 174696)
@@ -1,5 +1,23 @@
 2014-10-14  Joseph Pecoraro  <[email protected]>
 
+        Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
+        https://bugs.webkit.org/show_bug.cgi?id=137575
+
+        Reviewed by Simon Fraser.
+
+        Remove setShowPaintRects from the legacy iOS protocol definitions.
+        The methods were unimplemented by the backends, so they should
+        not advertise supporting it.
+
+        * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
+        * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+        * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
+        * Versions/Inspector-iOS-6.0.json:
+        * Versions/Inspector-iOS-7.0.json:
+        * Versions/InspectorWeb-iOS-8.0.json:
+
+2014-10-14  Joseph Pecoraro  <[email protected]>
+
         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
         https://bugs.webkit.org/show_bug.cgi?id=137681

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js (174695 => 174696)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js	2014-10-14 19:29:41 UTC (rev 174696)
@@ -57,7 +57,6 @@
 InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
 InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
 InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (174695 => 174696)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-10-14 19:29:41 UTC (rev 174696)
@@ -64,7 +64,6 @@
 InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
 InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
 InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
 InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js (174695 => 174696)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js	2014-10-14 19:29:41 UTC (rev 174696)
@@ -227,7 +227,6 @@
 InspectorBackend.registerCommand("Page.searchInResource", [{"name": "frameId", "type": "string", "optional": false}, {"name": "url", "type": "string", "optional": false}, {"name": "query", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.searchInResources", [{"name": "text", "type": "string", "optional": false}, {"name": "caseSensitive", "type": "boolean", "optional": true}, {"name": "isRegex", "type": "boolean", "optional": true}], ["result"]);
 InspectorBackend.registerCommand("Page.setDocumentContent", [{"name": "frameId", "type": "string", "optional": false}, {"name": "html", "type": "string", "optional": false}], []);
-InspectorBackend.registerCommand("Page.setShowPaintRects", [{"name": "result", "type": "boolean", "optional": false}], []);
 InspectorBackend.registerCommand("Page.getScriptExecutionStatus", [], ["result"]);
 InspectorBackend.registerCommand("Page.setScriptExecutionDisabled", [{"name": "value", "type": "boolean", "optional": false}], []);
 InspectorBackend.registerCommand("Page.setTouchEmulationEnabled", [{"name": "enabled", "type": "boolean", "optional": false}], []);

Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json (174695 => 174696)


--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json	2014-10-14 19:29:41 UTC (rev 174696)
@@ -238,13 +238,6 @@
                 ]
             },
             {
-                "name": "setShowPaintRects",
-                "description": "Requests that backend shows paint rectangles",
-                "parameters": [
-                    { "name": "result", "type": "boolean", "description": "True for showing paint rectangles" }
-                ]
-            },
-            {
                 "name": "getScriptExecutionStatus",
                 "description": "Determines if scripts can be executed in the page.",
                 "returns": [

Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (174695 => 174696)


--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-10-14 19:29:41 UTC (rev 174696)
@@ -237,13 +237,6 @@
                 ]
             },
             {
-                "name": "setShowPaintRects",
-                "description": "Requests that backend shows paint rectangles",
-                "parameters": [
-                    { "name": "result", "type": "boolean", "description": "True for showing paint rectangles" }
-                ]
-            },
-            {
                 "name": "getScriptExecutionStatus",
                 "description": "Determines if scripts can be executed in the page.",
                 "returns": [

Modified: trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json (174695 => 174696)


--- trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json	2014-10-14 19:24:27 UTC (rev 174695)
+++ trunk/Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json	2014-10-14 19:29:41 UTC (rev 174696)
@@ -2066,13 +2066,6 @@
             ]
         },
         {
-            "name": "setShowPaintRects",
-            "description": "Requests that backend shows paint rectangles",
-            "parameters": [
-                { "name": "result", "type": "boolean", "description": "True for showing paint rectangles" }
-            ]
-        },
-        {
             "name": "getScriptExecutionStatus",
             "description": "Determines if scripts can be executed in the page.",
             "returns": [

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to