Title: [174793] trunk
- Revision
- 174793
- Author
- [email protected]
- Date
- 2014-10-16 14:57:49 -0700 (Thu, 16 Oct 2014)
Log Message
Unreviewed, rolling out r174754.
https://bugs.webkit.org/show_bug.cgi?id=137789
Speculative fix for Windows test was ineffective. (Requested
by rfong on #webkit).
Reverted changeset:
"[Windows] Add some more logging to debug Windows test
issues."
http://trac.webkit.org/changeset/174754
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (174792 => 174793)
--- trunk/Source/WebKit/win/ChangeLog 2014-10-16 21:33:50 UTC (rev 174792)
+++ trunk/Source/WebKit/win/ChangeLog 2014-10-16 21:57:49 UTC (rev 174793)
@@ -1,3 +1,17 @@
+2014-10-16 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r174754.
+ https://bugs.webkit.org/show_bug.cgi?id=137789
+
+ Speculative fix for Windows test was ineffective. (Requested
+ by rfong on #webkit).
+
+ Reverted changeset:
+
+ "[Windows] Add some more logging to debug Windows test
+ issues."
+ http://trac.webkit.org/changeset/174754
+
2014-10-15 Roger Fong <[email protected]>
[Windows] Add some more logging to debug Windows test issues.
Modified: trunk/Source/WebKit/win/WebActionPropertyBag.cpp (174792 => 174793)
--- trunk/Source/WebKit/win/WebActionPropertyBag.cpp 2014-10-16 21:33:50 UTC (rev 174792)
+++ trunk/Source/WebKit/win/WebActionPropertyBag.cpp 2014-10-16 21:57:49 UTC (rev 174793)
@@ -111,12 +111,11 @@
if (!pszPropName)
return E_POINTER;
+ WTFLogAlways("pVar Pointer Value: %p", pVar);
VariantClear(pVar);
if (isEqual(pszPropName, WebActionNavigationTypeKey)) {
- WTFLogAlways("WebActionNavigationKey 1");
V_VT(pVar) = VT_I4;
- WTFLogAlways("WebActionNavigationKey 2");
V_I4(pVar) = m_action.type();
return S_OK;
}
@@ -136,7 +135,6 @@
}
if (isEqual(pszPropName, WebActionOriginalURLKey)) {
V_VT(pVar) = VT_BSTR;
- WTFLogAlways("WebActionOriginalURLKey");
V_BSTR(pVar) = BString(m_action.url().string()).release();
return S_OK;
}
Modified: trunk/Tools/ChangeLog (174792 => 174793)
--- trunk/Tools/ChangeLog 2014-10-16 21:33:50 UTC (rev 174792)
+++ trunk/Tools/ChangeLog 2014-10-16 21:57:49 UTC (rev 174793)
@@ -1,3 +1,17 @@
+2014-10-16 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r174754.
+ https://bugs.webkit.org/show_bug.cgi?id=137789
+
+ Speculative fix for Windows test was ineffective. (Requested
+ by rfong on #webkit).
+
+ Reverted changeset:
+
+ "[Windows] Add some more logging to debug Windows test
+ issues."
+ http://trac.webkit.org/changeset/174754
+
2014-10-15 Gyuyoung Kim <[email protected]>
Unreviewed, add myself to CoordinatedGraphics watchers.
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (174792 => 174793)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2014-10-16 21:33:50 UTC (rev 174792)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2014-10-16 21:57:49 UTC (rev 174793)
@@ -112,21 +112,6 @@
UINT_PTR waitToDumpWatchdog = 0;
-
-typedef int(*SETOANOCACHE)(void);
-
-void DisableBSTRCache()
-{
- HINSTANCE hLib = LoadLibrary(L"OLEAUT32.DLL");
- if (hLib != NULL)
- {
- SETOANOCACHE SetOaNoCache = (SETOANOCACHE)GetProcAddress(hLib, "SetOaNoCache");
- if (SetOaNoCache != NULL)
- SetOaNoCache();
- FreeLibrary(hLib);
- }
-}
-
void setPersistentUserStyleSheetLocation(CFStringRef url)
{
persistentUserStyleSheetLocation = url;
@@ -1262,7 +1247,6 @@
::SetErrorMode(0);
::SetUnhandledExceptionFilter(exceptionFilter);
- DisableBSTRCache();
leakChecking = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
