Title: [174797] trunk/Tools
Revision
174797
Author
[email protected]
Date
2014-10-16 15:43:02 -0700 (Thu, 16 Oct 2014)

Log Message

commit-queue: fails to close bugs after successfully landing patches
<http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174796 => 174797)


--- trunk/Tools/ChangeLog	2014-10-16 22:08:12 UTC (rev 174796)
+++ trunk/Tools/ChangeLog	2014-10-16 22:43:02 UTC (rev 174797)
@@ -1,3 +1,15 @@
+2014-10-16  David Kilzer  <[email protected]>
+
+        commit-queue: fails to close bugs after successfully landing patches
+        <http://webkit.org/b/137794>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
+        tell Mechanize to use the second <textarea> on the page with
+        name="comment".
+
 2014-10-16  Brent Fulgham  <[email protected]>
 
         [Win] Update DRT to match Mac Logic

Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (174796 => 174797)


--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2014-10-16 22:08:12 UTC (rev 174796)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py	2014-10-16 22:43:02 UTC (rev 174797)
@@ -754,7 +754,7 @@
 
         self.browser.open(self.attachment_url_for_id(attachment_id, 'edit'))
         self.browser.select_form(nr=1)
-        self.browser.set_value(comment_text, name='comment', nr=0)
+        self.browser.set_value(comment_text, name='comment', nr=1)
         self._find_select_element_for_flag('review').value = ("X",)
         self._find_select_element_for_flag('commit-queue').value = ("X",)
         self.browser.submit()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to