Title: [174800] trunk/Tools
- Revision
- 174800
- Author
- [email protected]
- Date
- 2014-10-16 16:55:59 -0700 (Thu, 16 Oct 2014)
Log Message
commit-queue: fails to replace OO-PS! with reviewer name
<http://webkit.org/b/137795>
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
email addresses to unauthenticated page loads, so we must always
authenticate before getting bug data so we get full email
addresses.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (174799 => 174800)
--- trunk/Tools/ChangeLog 2014-10-16 23:39:09 UTC (rev 174799)
+++ trunk/Tools/ChangeLog 2014-10-16 23:55:59 UTC (rev 174800)
@@ -1,5 +1,18 @@
2014-10-16 David Kilzer <[email protected]>
+ commit-queue: fails to replace OO-PS! with reviewer name
+ <http://webkit.org/b/137795>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
+ email addresses to unauthenticated page loads, so we must always
+ authenticate before getting bug data so we get full email
+ addresses.
+
+2014-10-16 David Kilzer <[email protected]>
+
commit-queue: fails to close bugs after successfully landing patches
<http://webkit.org/b/137794>
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (174799 => 174800)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2014-10-16 23:39:09 UTC (rev 174799)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2014-10-16 23:55:59 UTC (rev 174800)
@@ -468,12 +468,10 @@
def fetch_bug_dictionary(self, bug_id):
try:
+ self.authenticate()
return self._parse_bug_dictionary_from_xml(self._fetch_bug_page(bug_id))
except KeyboardInterrupt:
raise
- except:
- self.authenticate()
- return self._parse_bug_dictionary_from_xml(self._fetch_bug_page(bug_id))
# FIXME: A BugzillaCache object should provide all these fetch_ methods.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
