Title: [174802] trunk/Source/WebCore
- Revision
- 174802
- Author
- [email protected]
- Date
- 2014-10-16 18:12:51 -0700 (Thu, 16 Oct 2014)
Log Message
Missing RefPtr.release() calls in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=137777
Patch by Adrien Destugues <[email protected]> on 2014-10-16
Reviewed by Chris Dumez.
No new tests: no functional change, cleanup/optimization.
Avoids useless ref/deref cycle when returning from functions.
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintIntoSurface):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174801 => 174802)
--- trunk/Source/WebCore/ChangeLog 2014-10-17 00:35:59 UTC (rev 174801)
+++ trunk/Source/WebCore/ChangeLog 2014-10-17 01:12:51 UTC (rev 174802)
@@ -1,3 +1,19 @@
+2014-10-16 Adrien Destugues <[email protected]>
+
+ Missing RefPtr.release() calls in TextureMapper
+ https://bugs.webkit.org/show_bug.cgi?id=137777
+
+ Reviewed by Chris Dumez.
+
+ No new tests: no functional change, cleanup/optimization.
+
+ Avoids useless ref/deref cycle when returning from functions.
+
+ * platform/graphics/texmap/TextureMapper.cpp:
+ (WebCore::TextureMapper::acquireTextureFromPool):
+ * platform/graphics/texmap/TextureMapperLayer.cpp:
+ (WebCore::TextureMapperLayer::paintIntoSurface):
+
2014-10-16 Chris Dumez <[email protected]>
Use is<>() / downcast<>() for ContentData subclasses
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.cpp (174801 => 174802)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.cpp 2014-10-17 00:35:59 UTC (rev 174801)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapper.cpp 2014-10-17 01:12:51 UTC (rev 174802)
@@ -125,7 +125,7 @@
{
RefPtr<BitmapTexture> selectedTexture = m_texturePool->acquireTexture(size, this);
selectedTexture->reset(size, flags);
- return selectedTexture;
+ return selectedTexture.release();
}
std::unique_ptr<TextureMapper> TextureMapper::create(AccelerationMode mode)
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (174801 => 174802)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2014-10-17 00:35:59 UTC (rev 174801)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2014-10-17 01:12:51 UTC (rev 174802)
@@ -381,7 +381,7 @@
m_state.maskLayer->applyMask(options);
surface = surface->applyFilters(options.textureMapper, m_currentFilters);
options.textureMapper->bindSurface(surface.get());
- return surface;
+ return surface.release();
}
static void commitSurface(const TextureMapperPaintOptions& options, PassRefPtr<BitmapTexture> surface, const IntRect& rect, float opacity)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
