Title: [174832] trunk/Source/WebCore
- Revision
- 174832
- Author
- [email protected]
- Date
- 2014-10-17 13:35:06 -0700 (Fri, 17 Oct 2014)
Log Message
[Media] Always update controls for <audio> since they are always visible
https://bugs.webkit.org/show_bug.cgi?id=137829
<rdar://problem/18693987>
Reviewed by Brent Fulgham.
Revision 174756 made a change to only update the display of the controls
while they are visible. However, <audio> elements didn't detect visibility
the same way, since their controls do not auto-hide.
Change controlsAreHidden to check if we're an audio element.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.controlsAreHidden): Audio elements do not auto-hide their controls.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174831 => 174832)
--- trunk/Source/WebCore/ChangeLog 2014-10-17 20:02:17 UTC (rev 174831)
+++ trunk/Source/WebCore/ChangeLog 2014-10-17 20:35:06 UTC (rev 174832)
@@ -1,3 +1,20 @@
+2014-10-17 Dean Jackson <[email protected]>
+
+ [Media] Always update controls for <audio> since they are always visible
+ https://bugs.webkit.org/show_bug.cgi?id=137829
+ <rdar://problem/18693987>
+
+ Reviewed by Brent Fulgham.
+
+ Revision 174756 made a change to only update the display of the controls
+ while they are visible. However, <audio> elements didn't detect visibility
+ the same way, since their controls do not auto-hide.
+
+ Change controlsAreHidden to check if we're an audio element.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.controlsAreHidden): Audio elements do not auto-hide their controls.
+
2014-10-17 [email protected] <[email protected]>
[WinCairo] Accelerated compositing is not implemented.
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (174831 => 174832)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-10-17 20:02:17 UTC (rev 174831)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-10-17 20:35:06 UTC (rev 174832)
@@ -1037,7 +1037,7 @@
controlsAreHidden: function()
{
- return !this.controls.panel.classList.contains(this.ClassNames.show) || this.controls.panel.classList.contains(this.ClassNames.hidden);
+ return !this.isAudio() && !this.controls.panel.classList.contains(this.ClassNames.show) || this.controls.panel.classList.contains(this.ClassNames.hidden);
},
removeControls: function()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
