Title: [175064] trunk/Source/WebKit2
- Revision
- 175064
- Author
- [email protected]
- Date
- 2014-10-22 13:14:29 -0700 (Wed, 22 Oct 2014)
Log Message
Revert fix for REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
(https://bugs.webkit.org/show_bug.cgi?id=137493)
Turns out the root cause was a bug in MIME type sniffing, https://bugs.webkit.org/show_bug.cgi?id=137855
Remove the workaround.
* Shared/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::startWithHandle):
* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::startWithHandle):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (175063 => 175064)
--- trunk/Source/WebKit2/ChangeLog 2014-10-22 20:04:37 UTC (rev 175063)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-22 20:14:29 UTC (rev 175064)
@@ -1,3 +1,17 @@
+2014-10-22 Antti Koivisto <[email protected]>
+
+ Revert fix for REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
+ (https://bugs.webkit.org/show_bug.cgi?id=137493)
+
+ Turns out the root cause was a bug in MIME type sniffing, https://bugs.webkit.org/show_bug.cgi?id=137855
+
+ Remove the workaround.
+
+ * Shared/Downloads/ios/DownloadIOS.mm:
+ (WebKit::Download::startWithHandle):
+ * Shared/Downloads/mac/DownloadMac.mm:
+ (WebKit::Download::startWithHandle):
+
2014-10-22 Beth Dakin <[email protected]>
Remove action menu web preference
Modified: trunk/Source/WebKit2/Shared/Downloads/ios/DownloadIOS.mm (175063 => 175064)
--- trunk/Source/WebKit2/Shared/Downloads/ios/DownloadIOS.mm 2014-10-22 20:04:37 UTC (rev 175063)
+++ trunk/Source/WebKit2/Shared/Downloads/ios/DownloadIOS.mm 2014-10-22 20:14:29 UTC (rev 175064)
@@ -134,10 +134,6 @@
void Download::startWithHandle(ResourceHandle* handle, const ResourceResponse& response)
{
- // FIXME: For some reason the filename needs to be accessed or it may be incorrect after
- // CFURLResponse is serialized/deserialized (gains .txt extension)
- response.suggestedFilename();
-
CFURLDownloadClient client;
setUpDownloadClient(client, *this);
m_download = adoptCF(CFURLDownloadCreateAndStartWithLoadingConnection(NULL, handle->releaseConnectionForDownload().get(), m_request.cfURLRequest(UpdateHTTPBody), response.cfURLResponse(), &client));
Modified: trunk/Source/WebKit2/Shared/Downloads/mac/DownloadMac.mm (175063 => 175064)
--- trunk/Source/WebKit2/Shared/Downloads/mac/DownloadMac.mm 2014-10-22 20:04:37 UTC (rev 175063)
+++ trunk/Source/WebKit2/Shared/Downloads/mac/DownloadMac.mm 2014-10-22 20:14:29 UTC (rev 175064)
@@ -73,10 +73,6 @@
ASSERT(!m_nsURLDownload);
ASSERT(!m_delegate);
- // FIXME: For some reason the filename needs to be accessed or it may be incorrect after
- // NSURLResponse is serialized/deserialized (gains .txt extension)
- response.suggestedFilename();
-
m_delegate = adoptNS([[WKDownloadAsDelegate alloc] initWithDownload:this]);
m_nsURLDownload = [NSURLDownload _downloadWithLoadingConnection:handle->connection()
request:m_request.nsURLRequest(UpdateHTTPBody)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
