[webkit-changes] [175080] trunk/Source/JavaScriptCore

Wed, 22 Oct 2014 19:39:27 -0700

Title: [175080] trunk/Source/_javascript_Core
Revision
175080
Author
[email protected]
Date
2014-10-22 19:39:14 -0700 (Wed, 22 Oct 2014)

Log Message

Refactoring to simplify some code in DatePrototype.cpp.
<https://webkit.org/b/137997>

Reviewed by Filip Pizlo.

A bunch of functions in DatePrototype.cpp have the pattern of loading a
constant into a local variable only to pass it to a callee function
immediately after.  There is no other use for that variable.  This adds
additional verbosity with no added benefit.

This patch refactors those functions to just pass the constant arg directly.

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (175079 => 175080)


--- trunk/Source/_javascript_Core/ChangeLog	2014-10-23 01:37:08 UTC (rev 175079)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-10-23 02:39:14 UTC (rev 175080)
@@ -1,3 +1,33 @@
+2014-10-22  Mark Lam  <[email protected]>
+
+        Refactoring to simplify some code in DatePrototype.cpp.
+        <https://webkit.org/b/137997>
+
+        Reviewed by Filip Pizlo.
+
+        A bunch of functions in DatePrototype.cpp have the pattern of loading a
+        constant into a local variable only to pass it to a callee function
+        immediately after.  There is no other use for that variable.  This adds
+        additional verbosity with no added benefit.
+
+        This patch refactors those functions to just pass the constant arg directly.
+
+        * runtime/DatePrototype.cpp:
+        (JSC::dateProtoFuncSetMilliSeconds):
+        (JSC::dateProtoFuncSetUTCMilliseconds):
+        (JSC::dateProtoFuncSetSeconds):
+        (JSC::dateProtoFuncSetUTCSeconds):
+        (JSC::dateProtoFuncSetMinutes):
+        (JSC::dateProtoFuncSetUTCMinutes):
+        (JSC::dateProtoFuncSetHours):
+        (JSC::dateProtoFuncSetUTCHours):
+        (JSC::dateProtoFuncSetDate):
+        (JSC::dateProtoFuncSetUTCDate):
+        (JSC::dateProtoFuncSetMonth):
+        (JSC::dateProtoFuncSetUTCMonth):
+        (JSC::dateProtoFuncSetFullYear):
+        (JSC::dateProtoFuncSetUTCFullYear):
+
 2014-10-22  Byungseon Shin  <[email protected]>
 
         String(new Date(Mar 30 2014 01:00:00)) is wrong in CET

Modified: trunk/Source/_javascript_Core/runtime/DatePrototype.cpp (175079 => 175080)


--- trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2014-10-23 01:37:08 UTC (rev 175079)
+++ trunk/Source/_javascript_Core/runtime/DatePrototype.cpp	2014-10-23 02:39:14 UTC (rev 175080)
@@ -940,86 +940,72 @@
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMilliSeconds(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromTimeArgs(exec, 1, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 1, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMilliseconds(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromTimeArgs(exec, 1, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 1, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetSeconds(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromTimeArgs(exec, 2, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 2, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCSeconds(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromTimeArgs(exec, 2, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 2, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMinutes(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromTimeArgs(exec, 3, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 3, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMinutes(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromTimeArgs(exec, 3, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 3, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetHours(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromTimeArgs(exec, 4, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 4, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCHours(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromTimeArgs(exec, 4, inputTimeType);
+    return setNewValueFromTimeArgs(exec, 4, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetDate(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromDateArgs(exec, 1, inputTimeType);
+    return setNewValueFromDateArgs(exec, 1, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCDate(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromDateArgs(exec, 1, inputTimeType);
+    return setNewValueFromDateArgs(exec, 1, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetMonth(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromDateArgs(exec, 2, inputTimeType);
+    return setNewValueFromDateArgs(exec, 2, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCMonth(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromDateArgs(exec, 2, inputTimeType);
+    return setNewValueFromDateArgs(exec, 2, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetFullYear(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::LocalTime;
-    return setNewValueFromDateArgs(exec, 3, inputTimeType);
+    return setNewValueFromDateArgs(exec, 3, WTF::LocalTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetUTCFullYear(ExecState* exec)
 {
-    const WTF::TimeType inputTimeType = WTF::UTCTime;
-    return setNewValueFromDateArgs(exec, 3, inputTimeType);
+    return setNewValueFromDateArgs(exec, 3, WTF::UTCTime);
 }
 
 EncodedJSValue JSC_HOST_CALL dateProtoFuncSetYear(ExecState* exec)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to