Title: [175175] trunk/Source/WebCore
- Revision
- 175175
- Author
- [email protected]
- Date
- 2014-10-24 13:23:31 -0700 (Fri, 24 Oct 2014)
Log Message
REGRESSION(r174877): WebProcess sends an empty Cookies HTTP header
https://bugs.webkit.org/show_bug.cgi?id=138053
Reviewed by Chris Dumez.
Fixes existing tests.
* platform/network/mac/CookieJarMac.mm: (WebCore::cookiesForSession): Restore the
behavior of returning a null string when there are no cookies.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175174 => 175175)
--- trunk/Source/WebCore/ChangeLog 2014-10-24 20:12:44 UTC (rev 175174)
+++ trunk/Source/WebCore/ChangeLog 2014-10-24 20:23:31 UTC (rev 175175)
@@ -1,3 +1,15 @@
+2014-10-24 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION(r174877): WebProcess sends an empty Cookies HTTP header
+ https://bugs.webkit.org/show_bug.cgi?id=138053
+
+ Reviewed by Chris Dumez.
+
+ Fixes existing tests.
+
+ * platform/network/mac/CookieJarMac.mm: (WebCore::cookiesForSession): Restore the
+ behavior of returning a null string when there are no cookies.
+
2014-10-24 Chris Dumez <[email protected]>
[Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
Modified: trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm (175174 => 175175)
--- trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2014-10-24 20:12:44 UTC (rev 175174)
+++ trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm 2014-10-24 20:23:31 UTC (rev 175175)
@@ -76,6 +76,9 @@
BEGIN_BLOCK_OBJC_EXCEPTIONS;
NSArray *cookies = wkHTTPCookiesForURL(session.cookieStorage().get(), firstParty, url);
+ if (![cookies count])
+ return String(); // Return a null string, not an empty one that StringBuilder would create below.
+
StringBuilder cookiesBuilder;
for (NSHTTPCookie *cookie in cookies) {
if (![[cookie name] length])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
