Title: [175179] trunk/Source/WebKit2
- Revision
- 175179
- Author
- [email protected]
- Date
- 2014-10-24 14:13:14 -0700 (Fri, 24 Oct 2014)
Log Message
[Mac][WebKit2] Move action menu code into its own file
https://bugs.webkit.org/show_bug.cgi?id=138034
<rdar://problem/18758758>
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _addImageToPhotos:]):
Review comments that were not previously addressed.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (175178 => 175179)
--- trunk/Source/WebKit2/ChangeLog 2014-10-24 21:08:20 UTC (rev 175178)
+++ trunk/Source/WebKit2/ChangeLog 2014-10-24 21:13:14 UTC (rev 175179)
@@ -4,6 +4,17 @@
https://bugs.webkit.org/show_bug.cgi?id=138034
<rdar://problem/18758758>
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController prepareForMenu:withEvent:]):
+ (-[WKActionMenuController _addImageToPhotos:]):
+ Review comments that were not previously addressed.
+
+2014-10-24 Tim Horton <[email protected]>
+
+ [Mac][WebKit2] Move action menu code into its own file
+ https://bugs.webkit.org/show_bug.cgi?id=138034
+ <rdar://problem/18758758>
+
Reviewed by Dan Bernstein.
* UIProcess/API/mac/WKView.mm:
Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (175178 => 175179)
--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-10-24 21:08:20 UTC (rev 175178)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-10-24 21:13:14 UTC (rev 175179)
@@ -106,7 +106,7 @@
[self _updateActionMenuItems];
- _page->performActionMenuHitTestAtLocation([_wkView convertPoint:[event locationInWindow] fromView:nil]);
+ _page->performActionMenuHitTestAtLocation([_wkView convertPoint:event.locationInWindow fromView:nil]);
_state = ActionMenuState::Pending;
}
@@ -278,7 +278,7 @@
- (void)_addImageToPhotos:(id)sender
{
- // FIXME: We shouldn't even add the button if this is the case, for now.
+ // FIXME: We shouldn't even add the menu item if this is the case, for now.
if (![getIKSlideshowClass() canExportToApplication:@"com.apple.Photos"])
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
