Title: [175209] trunk/Source/WebCore
Revision
175209
Author
[email protected]
Date
2014-10-25 22:47:13 -0700 (Sat, 25 Oct 2014)

Log Message

Remove a useless variable from SelectorCodeGenerator::generateElementMatchesSelectorList()
https://bugs.webkit.org/show_bug.cgi?id=138076

Reviewed by Alexey Proskuryakov.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
The variable elementAddressRegisterIndex was just needed for debugging, it is useless now.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (175208 => 175209)


--- trunk/Source/WebCore/ChangeLog	2014-10-26 04:44:01 UTC (rev 175208)
+++ trunk/Source/WebCore/ChangeLog	2014-10-26 05:47:13 UTC (rev 175209)
@@ -1,3 +1,14 @@
+2014-10-25  Benjamin Poulain  <[email protected]>
+
+        Remove a useless variable from SelectorCodeGenerator::generateElementMatchesSelectorList()
+        https://bugs.webkit.org/show_bug.cgi?id=138076
+
+        Reviewed by Alexey Proskuryakov.
+
+        * cssjit/SelectorCompiler.cpp:
+        (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
+        The variable elementAddressRegisterIndex was just needed for debugging, it is useless now.
+
 2014-10-18  Brian J. Burg  <[email protected]>
 
         Web Inspector: timelines should not count time elapsed while paused in the debugger

Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (175208 => 175209)


--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp	2014-10-26 04:44:01 UTC (rev 175208)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp	2014-10-26 05:47:13 UTC (rev 175209)
@@ -1752,25 +1752,20 @@
     // The contract is that existing registers are preserved. Two special cases are elementToMatch and elementAddressRegister
     // because they are used by the matcher itself.
     // To simplify things for now, we just always preserve them on the stack.
-    unsigned elementAddressRegisterIndex = std::numeric_limits<unsigned>::max();
-    unsigned elementToTestIndex = elementAddressRegisterIndex;
+    unsigned elementToTestIndex = std::numeric_limits<unsigned>::max();
     bool isElementToMatchOnStack = false;
     if (selectorList.clobberElementAddressRegister) {
         if (elementToMatch != elementAddressRegister) {
             registersToSave.append(elementAddressRegister);
             registersToSave.append(elementToMatch);
-            elementAddressRegisterIndex = 0;
             elementToTestIndex = 1;
             isElementToMatchOnStack = true;
         } else {
             registersToSave.append(elementAddressRegister);
-            elementAddressRegisterIndex = 0;
             elementToTestIndex = 0;
         }
-    } else if (elementToMatch != elementAddressRegister) {
+    } else if (elementToMatch != elementAddressRegister)
         registersToSave.append(elementAddressRegister);
-        elementAddressRegisterIndex = 0;
-    }
 
     // Next, we need to free as many registers as needed by the nested selector list.
     unsigned availableRegisterCount = m_registerAllocator.availableRegisterCount();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to