Title: [175327] trunk/Tools
- Revision
- 175327
- Author
- [email protected]
- Date
- 2014-10-29 03:45:27 -0700 (Wed, 29 Oct 2014)
Log Message
[EFL] build-webkit should try harder to avoid re-running cmake
https://bugs.webkit.org/show_bug.cgi?id=137949
Reviewed by Martin Robinson.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
(generateBuildSystemFromCMakeProject): Comment fix after r174681.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (175326 => 175327)
--- trunk/Tools/ChangeLog 2014-10-29 08:59:31 UTC (rev 175326)
+++ trunk/Tools/ChangeLog 2014-10-29 10:45:27 UTC (rev 175327)
@@ -1,3 +1,14 @@
+2014-10-29 Csaba Osztrogonác <[email protected]>
+
+ [EFL] build-webkit should try harder to avoid re-running cmake
+ https://bugs.webkit.org/show_bug.cgi?id=137949
+
+ Reviewed by Martin Robinson.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
+ (generateBuildSystemFromCMakeProject): Comment fix after r174681.
+
2014-10-28 Daniel Bates <[email protected]>
Unify logic in RunTests.run() to run the Python unit tests
Modified: trunk/Tools/Scripts/webkitdirs.pm (175326 => 175327)
--- trunk/Tools/Scripts/webkitdirs.pm 2014-10-29 08:59:31 UTC (rev 175326)
+++ trunk/Tools/Scripts/webkitdirs.pm 2014-10-29 10:45:27 UTC (rev 175327)
@@ -1682,10 +1682,6 @@
{
my ($cacheFilePath, @buildArgs) = @_;
- if (!isGtk()) {
- return 1;
- }
-
# We check this first, because we always want to create this file for a fresh build.
my $productDir = File::Spec->catdir(baseProductDir(), configuration());
my $optionsCache = File::Spec->catdir($productDir, "build-webkit-options.txt");
@@ -1759,7 +1755,7 @@
my $originalWorkingDirectory = getcwd();
chdir($buildPath) or die;
- # For GTK+ we try to be smart about when to rerun cmake, so that we can have faster incremental builds.
+ # We try to be smart about when to rerun cmake, so that we can have faster incremental builds.
my $willUseNinja = canUseNinja();
if (-e cmakeCachePath() && -e cmakeGeneratedBuildfile($willUseNinja)) {
return 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
