Title: [175418] trunk/Source/WebKit2
Revision
175418
Author
[email protected]
Date
2014-10-31 13:21:26 -0700 (Fri, 31 Oct 2014)

Log Message

Remove "Add to iPhoto" from the action menu's sharing menu
https://bugs.webkit.org/show_bug.cgi?id=138251
<rdar://problem/18837197>

Reviewed by Anders Carlsson.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
Retain/autorelease the new array.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (175417 => 175418)


--- trunk/Source/WebKit2/ChangeLog	2014-10-31 20:16:32 UTC (rev 175417)
+++ trunk/Source/WebKit2/ChangeLog	2014-10-31 20:21:26 UTC (rev 175418)
@@ -1,3 +1,15 @@
+2014-10-31  Timothy Horton  <[email protected]>
+
+        Remove "Add to iPhoto" from the action menu's sharing menu
+        https://bugs.webkit.org/show_bug.cgi?id=138251
+        <rdar://problem/18837197>
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
+        Retain/autorelease the new array.
+
 2014-10-31  Tim Horton  <[email protected]>
 
         Remove "Add to iPhoto" from the action menu's sharing menu

Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (175417 => 175418)


--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-10-31 20:16:32 UTC (rev 175417)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-10-31 20:21:26 UTC (rev 175418)
@@ -348,7 +348,7 @@
 
 - (NSArray *)sharingServicePicker:(NSSharingServicePicker *)sharingServicePicker sharingServicesForItems:(NSArray *)items mask:(NSSharingServiceMask)mask proposedSharingServices:(NSArray *)proposedServices
 {
-    NSMutableArray *services = [[NSMutableArray alloc] initWithCapacity:proposedServices.count];
+    RetainPtr<NSMutableArray> services = adoptNS([[NSMutableArray alloc] initWithCapacity:proposedServices.count]);
 
     for (NSSharingService *service in proposedServices) {
         if ([service.name isEqualToString:NSSharingServiceNameAddToIPhoto])
@@ -356,7 +356,7 @@
         [services addObject:service];
     }
 
-    return services;
+    return services.autorelease();
 }
 
 - (id <NSSharingServiceDelegate>)sharingServicePicker:(NSSharingServicePicker *)sharingServicePicker delegateForSharingService:(NSSharingService *)sharingService
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to