Title: [175450] trunk
- Revision
- 175450
- Author
- [email protected]
- Date
- 2014-11-01 02:55:47 -0700 (Sat, 01 Nov 2014)
Log Message
REGRESSION(CMake): Make it possible to build without introspection
https://bugs.webkit.org/show_bug.cgi?id=138006
Reviewed by Philippe Normand.
.:
Add ENABLE_INTROSPECTION option.
* Source/PlatformGTK.cmake: Dot not add gir global target if
introspection is disabled.
* Source/cmake/OptionsGTK.cmake: Do not add gir individual targets if
introspection is disabled.
Source/_javascript_Core:
Do not install introspection files when introspection is disabled.
* PlatformGTK.cmake:
Source/WebKit2:
Do not install introspection files when introspection is disabled.
* PlatformGTK.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (175449 => 175450)
--- trunk/ChangeLog 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/ChangeLog 2014-11-01 09:55:47 UTC (rev 175450)
@@ -1,3 +1,17 @@
+2014-11-01 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(CMake): Make it possible to build without introspection
+ https://bugs.webkit.org/show_bug.cgi?id=138006
+
+ Reviewed by Philippe Normand.
+
+ Add ENABLE_INTROSPECTION option.
+
+ * Source/PlatformGTK.cmake: Dot not add gir global target if
+ introspection is disabled.
+ * Source/cmake/OptionsGTK.cmake: Do not add gir individual targets if
+ introspection is disabled.
+
2014-10-31 Adrian Perez de Castro <[email protected]>
[GTK] Support script message handlers WebKitUserContentManager
Modified: trunk/Source/_javascript_Core/ChangeLog (175449 => 175450)
--- trunk/Source/_javascript_Core/ChangeLog 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-11-01 09:55:47 UTC (rev 175450)
@@ -1,3 +1,14 @@
+2014-11-01 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(CMake): Make it possible to build without introspection
+ https://bugs.webkit.org/show_bug.cgi?id=138006
+
+ Reviewed by Philippe Normand.
+
+ Do not install introspection files when introspection is disabled.
+
+ * PlatformGTK.cmake:
+
2014-10-31 Gyuyoung Kim <[email protected]>
Use std::unique_ptr for TypeCountSet
Modified: trunk/Source/_javascript_Core/PlatformGTK.cmake (175449 => 175450)
--- trunk/Source/_javascript_Core/PlatformGTK.cmake 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/_javascript_Core/PlatformGTK.cmake 2014-11-01 09:55:47 UTC (rev 175450)
@@ -23,12 +23,15 @@
DESTINATION "${WEBKITGTK_HEADER_INSTALL_DIR}/_javascript_Core"
)
-install(FILES ${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.gir
- DESTINATION ${INTROSPECTION_INSTALL_GIRDIR}
-)
-install(FILES ${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.typelib
- DESTINATION ${INTROSPECTION_INSTALL_TYPELIBDIR}
-)
+if (ENABLE_INTROSPECTION)
+ install(FILES ${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.gir
+ DESTINATION ${INTROSPECTION_INSTALL_GIRDIR}
+ )
+ install(FILES ${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.typelib
+ DESTINATION ${INTROSPECTION_INSTALL_TYPELIBDIR}
+ )
+endif ()
+
add_definitions(-DSTATICALLY_LINKED_WITH_WTF)
list(APPEND _javascript_Core_LIBRARIES
Modified: trunk/Source/PlatformGTK.cmake (175449 => 175450)
--- trunk/Source/PlatformGTK.cmake 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/PlatformGTK.cmake 2014-11-01 09:55:47 UTC (rev 175450)
@@ -1,7 +1,9 @@
add_subdirectory(${WEBCORE_DIR}/platform/gtk/po)
# This allows exposing a 'gir' target which builds all GObject introspection files.
-add_custom_target(gir ALL DEPENDS ${GObjectIntrospectionTargets})
+if (ENABLE_INTROSPECTION)
+ add_custom_target(gir ALL DEPENDS ${GObjectIntrospectionTargets})
+endif ()
list(APPEND DocumentationDependencies
GObjectDOMBindings
Modified: trunk/Source/WebKit2/ChangeLog (175449 => 175450)
--- trunk/Source/WebKit2/ChangeLog 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-01 09:55:47 UTC (rev 175450)
@@ -1,3 +1,14 @@
+2014-11-01 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(CMake): Make it possible to build without introspection
+ https://bugs.webkit.org/show_bug.cgi?id=138006
+
+ Reviewed by Philippe Normand.
+
+ Do not install introspection files when introspection is disabled.
+
+ * PlatformGTK.cmake:
+
2014-10-31 Dan Bernstein <[email protected]>
Removed a reference to a file that’s been deleted.
Modified: trunk/Source/WebKit2/PlatformGTK.cmake (175449 => 175450)
--- trunk/Source/WebKit2/PlatformGTK.cmake 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/WebKit2/PlatformGTK.cmake 2014-11-01 09:55:47 UTC (rev 175450)
@@ -830,15 +830,18 @@
${WebKit2WebExtension_INSTALLED_HEADERS}
DESTINATION "${WEBKITGTK_HEADER_INSTALL_DIR}/webkit2"
)
-install(FILES ${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
- ${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
- DESTINATION ${INTROSPECTION_INSTALL_GIRDIR}
-)
-install(FILES ${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.typelib
- ${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.typelib
- DESTINATION ${INTROSPECTION_INSTALL_TYPELIBDIR}
-)
+if (ENABLE_INTROSPECTION)
+ install(FILES ${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
+ ${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
+ DESTINATION ${INTROSPECTION_INSTALL_GIRDIR}
+ )
+ install(FILES ${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.typelib
+ ${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.typelib
+ DESTINATION ${INTROSPECTION_INSTALL_TYPELIBDIR}
+ )
+endif ()
+
file(WRITE ${CMAKE_BINARY_DIR}/gtkdoc-webkit2gtk.cfg
"[webkit2gtk]\n"
"pkgconfig_file=${WebKit2_PKGCONFIG_FILE}\n"
Modified: trunk/Source/cmake/OptionsGTK.cmake (175449 => 175450)
--- trunk/Source/cmake/OptionsGTK.cmake 2014-11-01 05:34:37 UTC (rev 175449)
+++ trunk/Source/cmake/OptionsGTK.cmake 2014-11-01 09:55:47 UTC (rev 175450)
@@ -15,6 +15,7 @@
set(ENABLE_GTKDOC OFF CACHE BOOL "Whether or not to use generate gtkdoc.")
set(ENABLE_X11_TARGET ON CACHE BOOL "Whether to enable support for the X11 windowing target.")
set(ENABLE_WAYLAND_TARGET OFF CACHE BOOL "Whether to enable support for the Wayland windowing target.")
+set(ENABLE_INTROSPECTION ON CACHE BOOL "Whether to enable GObject introspection.")
# These are shared variables, but we special case their definition so that we can use the
# CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.
@@ -350,10 +351,12 @@
# Add a typelib file to the list of all typelib dependencies. This makes it easy to
# expose a 'gir' target with all gobject-introspection files.
macro(ADD_TYPELIB typelib)
- get_filename_component(target_name ${typelib} NAME_WE)
- add_custom_target(${target_name}-gir ALL DEPENDS ${typelib})
- list(APPEND GObjectIntrospectionTargets ${target_name}-gir)
- set(GObjectIntrospectionTargets ${GObjectIntrospectionTargets} PARENT_SCOPE)
+ if (ENABLE_INTROSPECTION)
+ get_filename_component(target_name ${typelib} NAME_WE)
+ add_custom_target(${target_name}-gir ALL DEPENDS ${typelib})
+ list(APPEND GObjectIntrospectionTargets ${target_name}-gir)
+ set(GObjectIntrospectionTargets ${GObjectIntrospectionTargets} PARENT_SCOPE)
+ endif ()
endmacro()
# CMake does not automatically add --whole-archive when building shared objects from
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
