Title: [175460] trunk
- Revision
- 175460
- Author
- [email protected]
- Date
- 2014-11-01 23:59:49 -0700 (Sat, 01 Nov 2014)
Log Message
REGRESSION: Using a media element changes window.name
https://bugs.webkit.org/show_bug.cgi?id=138278
rdar://problem/18704134
Reviewed by Jer Noble.
Source/WebCore:
Test: fast/media/window-name.html
Use an actual variable for name (and while at it, for "item" as well).
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.disconnectControls):
LayoutTests:
* fast/media/window-name-expected.txt: Added.
* fast/media/window-name.html: Added.
* platform/mac/webarchive/loading/video-in-webarchive-expected.txt: Removed.
This result was incorrect due to this bug, and now Mac matches cross-platform
results.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (175459 => 175460)
--- trunk/LayoutTests/ChangeLog 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/LayoutTests/ChangeLog 2014-11-02 06:59:49 UTC (rev 175460)
@@ -1,3 +1,18 @@
+2014-11-01 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION: Using a media element changes window.name
+ https://bugs.webkit.org/show_bug.cgi?id=138278
+ rdar://problem/18704134
+
+ Reviewed by Jer Noble.
+
+ * fast/media/window-name-expected.txt: Added.
+ * fast/media/window-name.html: Added.
+
+ * platform/mac/webarchive/loading/video-in-webarchive-expected.txt: Removed.
+ This result was incorrect due to this bug, and now Mac matches cross-platform
+ results.
+
2014-11-01 Chris Dumez <[email protected]>
Unreviewed gardening.
Added: trunk/LayoutTests/fast/media/window-name-expected.txt (0 => 175460)
--- trunk/LayoutTests/fast/media/window-name-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/media/window-name-expected.txt 2014-11-02 06:59:49 UTC (rev 175460)
@@ -0,0 +1,10 @@
+Test that having an audio element in DOM doesn't magically change window.name.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.name is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/fast/media/window-name-expected.txt
___________________________________________________________________
Added: svn:mime-type
Added: svn:eol-style
Added: trunk/LayoutTests/fast/media/window-name.html (0 => 175460)
--- trunk/LayoutTests/fast/media/window-name.html (rev 0)
+++ trunk/LayoutTests/fast/media/window-name.html 2014-11-02 06:59:49 UTC (rev 175460)
@@ -0,0 +1,18 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<script src=""
+</head>
+<body>
+<audio controls></audio>
+<script>
+
+description("Test that having an audio element in DOM doesn't magically change window.name.");
+
+shouldBeEqualToString("window.name", "");
+
+</script>
+<script src=""
+</body>
+</html>
Property changes on: trunk/LayoutTests/fast/media/window-name.html
___________________________________________________________________
Added: svn:mime-type
Deleted: trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt (175459 => 175460)
--- trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/LayoutTests/platform/mac/webarchive/loading/video-in-webarchive-expected.txt 2014-11-02 06:59:49 UTC (rev 175460)
@@ -1,16 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-main frame - willPerformClientRedirectToURL: resources/video-in-webarchive.webarchive
-main frame - didFinishDocumentLoadForFrame
-main frame - didFinishLoadForFrame
-main frame - didStartProvisionalLoadForFrame
-main frame - didCancelClientRedirectForFrame
-main frame - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFailLoadWithError
-main frame "webkitendfullscreen" - didFinishLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
-
Modified: trunk/Source/WebCore/ChangeLog (175459 => 175460)
--- trunk/Source/WebCore/ChangeLog 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/Source/WebCore/ChangeLog 2014-11-02 06:59:49 UTC (rev 175460)
@@ -1,3 +1,20 @@
+2014-11-01 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION: Using a media element changes window.name
+ https://bugs.webkit.org/show_bug.cgi?id=138278
+ rdar://problem/18704134
+
+ Reviewed by Jer Noble.
+
+ Test: fast/media/window-name.html
+
+ Use an actual variable for name (and while at it, for "item" as well).
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.addVideoListeners):
+ (Controller.prototype.removeVideoListeners):
+ (Controller.prototype.disconnectControls):
+
2014-11-01 Chris Dumez <[email protected]>
Move "direction" CSS property to the new StyleBuilder
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (175459 => 175460)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-11-02 06:55:40 UTC (rev 175459)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2014-11-02 06:59:49 UTC (rev 175460)
@@ -152,7 +152,7 @@
addVideoListeners: function()
{
- for (name in this.HandledVideoEvents) {
+ for (var name in this.HandledVideoEvents) {
this.listenFor(this.video, name, this.HandledVideoEvents[name]);
};
@@ -178,7 +178,7 @@
removeVideoListeners: function()
{
- for (name in this.HandledVideoEvents) {
+ for (var name in this.HandledVideoEvents) {
this.stopListeningFor(this.video, name, this.HandledVideoEvents[name]);
};
@@ -432,7 +432,7 @@
disconnectControls: function(event)
{
- for (item in this.controls) {
+ for (var item in this.controls) {
var control = this.controls[item];
if (control && control.parentNode)
control.parentNode.removeChild(control);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
