Title: [175477] trunk/Source/WebCore
- Revision
- 175477
- Author
- [email protected]
- Date
- 2014-11-03 11:19:55 -0800 (Mon, 03 Nov 2014)
Log Message
REGRESSION: Using a media element changes window.name
https://bugs.webkit.org/show_bug.cgi?id=138278
rdar://problem/18704134
Apply the same fix to mediaControlsBase.js. I do not know who uses this file, but
there is no reason to have the bug there.
* Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.disconnectControls):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175476 => 175477)
--- trunk/Source/WebCore/ChangeLog 2014-11-03 19:17:20 UTC (rev 175476)
+++ trunk/Source/WebCore/ChangeLog 2014-11-03 19:19:55 UTC (rev 175477)
@@ -1,3 +1,17 @@
+2014-11-03 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION: Using a media element changes window.name
+ https://bugs.webkit.org/show_bug.cgi?id=138278
+ rdar://problem/18704134
+
+ Apply the same fix to mediaControlsBase.js. I do not know who uses this file, but
+ there is no reason to have the bug there.
+
+ * Modules/mediacontrols/mediaControlsBase.js:
+ (Controller.prototype.addVideoListeners):
+ (Controller.prototype.removeVideoListeners):
+ (Controller.prototype.disconnectControls):
+
2014-11-03 Andreas Kling <[email protected]>
RenderLayerModelObject shouldn't need a pre-destructor hook.
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js (175476 => 175477)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js 2014-11-03 19:17:20 UTC (rev 175476)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js 2014-11-03 19:19:55 UTC (rev 175477)
@@ -155,7 +155,7 @@
addVideoListeners: function()
{
- for (name in this.HandledVideoEvents) {
+ for (var name in this.HandledVideoEvents) {
this.listenFor(this.video, name, this.HandledVideoEvents[name]);
};
@@ -181,7 +181,7 @@
removeVideoListeners: function()
{
- for (name in this.HandledVideoEvents) {
+ for (var name in this.HandledVideoEvents) {
this.stopListeningFor(this.video, name, this.HandledVideoEvents[name]);
};
@@ -437,7 +437,7 @@
disconnectControls: function(event)
{
- for (item in this.controls) {
+ for (var item in this.controls) {
var control = this.controls[item];
if (control && control.parentNode)
control.parentNode.removeChild(control);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
