Title: [175704] trunk/Source/WebKit2
- Revision
- 175704
- Author
- [email protected]
- Date
- 2014-11-06 11:04:02 -0800 (Thu, 06 Nov 2014)
Log Message
Only provide a single result to the action menu DDActionContext
https://bugs.webkit.org/show_bug.cgi?id=138469
<rdar://problem/18869036>
Reviewed by Anders Carlsson.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::scanForDataDetectedItems):
Only provide one result; secondary results can be extremely unrelated to
the primary one and confuse Data Detectors further down the line.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (175703 => 175704)
--- trunk/Source/WebKit2/ChangeLog 2014-11-06 19:02:49 UTC (rev 175703)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-06 19:04:02 UTC (rev 175704)
@@ -1,5 +1,18 @@
2014-11-06 Tim Horton <[email protected]>
+ Only provide a single result to the action menu DDActionContext
+ https://bugs.webkit.org/show_bug.cgi?id=138469
+ <rdar://problem/18869036>
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/WebPage/mac/WebPageMac.mm:
+ (WebKit::scanForDataDetectedItems):
+ Only provide one result; secondary results can be extremely unrelated to
+ the primary one and confuse Data Detectors further down the line.
+
+2014-11-06 Tim Horton <[email protected]>
+
Null deref in rangeForDictionaryLookupAtHitTestResult on occasion
https://bugs.webkit.org/show_bug.cgi?id=138459
<rdar://problem/18872825>
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (175703 => 175704)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2014-11-06 19:02:49 UTC (rev 175703)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2014-11-06 19:04:02 UTC (rev 175704)
@@ -1127,7 +1127,7 @@
return nullptr;
RetainPtr<DDActionContext> actionContext = adoptNS([[getDDActionContextClass() alloc] init]);
- [actionContext setAllResults:(NSArray *)results.get()];
+ [actionContext setAllResults:@[ (id)mainResult ]];
[actionContext setMainResult:mainResult];
Vector<FloatQuad> quads;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes