Title: [175774] trunk/Tools
- Revision
- 175774
- Author
- [email protected]
- Date
- 2014-11-08 02:47:08 -0800 (Sat, 08 Nov 2014)
Log Message
WTR crashes after running a test when NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=138500
Reviewed by Alexey Proskuryakov.
WebNotificationProvider destructor is calling
WKNotificationManagerSetProvider, but m_notificationManager is
null because removeNotificationManager was already called.
* WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::~WebNotificationProvider): Check
m_notificationManager is not null before calling WKNotificationManagerSetProvider.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (175773 => 175774)
--- trunk/Tools/ChangeLog 2014-11-08 04:25:45 UTC (rev 175773)
+++ trunk/Tools/ChangeLog 2014-11-08 10:47:08 UTC (rev 175774)
@@ -1,3 +1,18 @@
+2014-11-08 Carlos Garcia Campos <[email protected]>
+
+ WTR crashes after running a test when NetworkProcess enabled
+ https://bugs.webkit.org/show_bug.cgi?id=138500
+
+ Reviewed by Alexey Proskuryakov.
+
+ WebNotificationProvider destructor is calling
+ WKNotificationManagerSetProvider, but m_notificationManager is
+ null because removeNotificationManager was already called.
+
+ * WebKitTestRunner/WebNotificationProvider.cpp:
+ (WTR::WebNotificationProvider::~WebNotificationProvider): Check
+ m_notificationManager is not null before calling WKNotificationManagerSetProvider.
+
2014-11-06 Jake Nielsen <[email protected]>
Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
Modified: trunk/Tools/WebKitTestRunner/WebNotificationProvider.cpp (175773 => 175774)
--- trunk/Tools/WebKitTestRunner/WebNotificationProvider.cpp 2014-11-08 04:25:45 UTC (rev 175773)
+++ trunk/Tools/WebKitTestRunner/WebNotificationProvider.cpp 2014-11-08 10:47:08 UTC (rev 175774)
@@ -65,7 +65,8 @@
WebNotificationProvider::~WebNotificationProvider()
{
- WKNotificationManagerSetProvider(m_notificationManager.get(), 0);
+ if (m_notificationManager)
+ WKNotificationManagerSetProvider(m_notificationManager.get(), nullptr);
}
WKNotificationProviderV0 WebNotificationProvider::provider()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
