Title: [175797] trunk/Source/WebKit2
- Revision
- 175797
- Author
- [email protected]
- Date
- 2014-11-09 21:48:35 -0800 (Sun, 09 Nov 2014)
Log Message
Unreviewed, fix typo in r175796.
Rename areEssentialEqualAsFloat to areEssentiallyEqualAsFloat.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::areEssentiallyEqualAsFloat):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::areEssentialEqualAsFloat): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (175796 => 175797)
--- trunk/Source/WebKit2/ChangeLog 2014-11-10 00:21:56 UTC (rev 175796)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-10 05:48:35 UTC (rev 175797)
@@ -1,5 +1,16 @@
2014-11-09 Chris Dumez <[email protected]>
+ Unreviewed, fix typo in r175796.
+
+ Rename areEssentialEqualAsFloat to areEssentiallyEqualAsFloat.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::areEssentiallyEqualAsFloat):
+ (WebKit::WebPage::dynamicViewportSizeUpdate):
+ (WebKit::areEssentialEqualAsFloat): Deleted.
+
+2014-11-09 Chris Dumez <[email protected]>
+
Add a more correct way to compare floating point numbers and use it
https://bugs.webkit.org/show_bug.cgi?id=138527
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (175796 => 175797)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-11-10 00:21:56 UTC (rev 175796)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-11-10 05:48:35 UTC (rev 175797)
@@ -2214,7 +2214,7 @@
// WebCore stores the page scale factor as float instead of double. When we get a scale from WebCore,
// we need to ignore differences that are within a small rounding error on floats.
-static inline bool areEssentialEqualAsFloat(float a, float b)
+static inline bool areEssentiallyEqualAsFloat(float a, float b)
{
return WTF::areEssentiallyEqual(a, b);
}
@@ -2285,7 +2285,7 @@
FloatRect newUnobscuredContentRect = targetUnobscuredRect;
FloatRect newExposedContentRect = targetExposedContentRect;
- bool scaleChanged = !areEssentialEqualAsFloat(scale, targetScale);
+ bool scaleChanged = !areEssentiallyEqualAsFloat(scale, targetScale);
if (scaleChanged) {
// The target scale the UI is using cannot be reached by the content. We need to compute new targets based
// on the viewport constraint and report everything back to the UIProcess.
@@ -2350,7 +2350,7 @@
newExposedContentRect.setY(0);
}
- bool likelyResponsiveDesignViewport = newLayoutSize.width() == minimumLayoutSize.width() && areEssentialEqualAsFloat(scale, 1);
+ bool likelyResponsiveDesignViewport = newLayoutSize.width() == minimumLayoutSize.width() && areEssentiallyEqualAsFloat(scale, 1);
bool contentBleedsOutsideLayoutWidth = newContentSize.width() > newLayoutSize.width();
bool originalScrollPositionWasOnTheLeftEdge = targetUnobscuredRect.x() <= 0;
if (likelyResponsiveDesignViewport && contentBleedsOutsideLayoutWidth && originalScrollPositionWasOnTheLeftEdge) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
