Title: [175963] trunk/Source
- Revision
- 175963
- Author
- [email protected]
- Date
- 2014-11-11 11:17:11 -0800 (Tue, 11 Nov 2014)
Log Message
Data Detectors popovers should be dismissed upon scrolling
https://bugs.webkit.org/show_bug.cgi?id=138600
<rdar://problem/18932770>
Reviewed by Beth Dakin.
* platform/spi/mac/DataDetectorsSPI.h:
Adjust the SPI header.
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
Dismiss popovers when we start preparing another menu.
(-[WKActionMenuController dismissActionMenuPopovers]):
Use the new DataDetectors SPI.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175962 => 175963)
--- trunk/Source/WebCore/ChangeLog 2014-11-11 19:14:07 UTC (rev 175962)
+++ trunk/Source/WebCore/ChangeLog 2014-11-11 19:17:11 UTC (rev 175963)
@@ -1,5 +1,16 @@
2014-11-11 Tim Horton <[email protected]>
+ Data Detectors popovers should be dismissed upon scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=138600
+ <rdar://problem/18932770>
+
+ Reviewed by Beth Dakin.
+
+ * platform/spi/mac/DataDetectorsSPI.h:
+ Adjust the SPI header.
+
+2014-11-11 Tim Horton <[email protected]>
+
Localize strings for action menus
https://bugs.webkit.org/show_bug.cgi?id=138591
<rdar://problem/18815343>
Modified: trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h (175962 => 175963)
--- trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h 2014-11-11 19:14:07 UTC (rev 175962)
+++ trunk/Source/WebCore/platform/spi/mac/DataDetectorsSPI.h 2014-11-11 19:17:11 UTC (rev 175963)
@@ -74,6 +74,6 @@
+ (DDActionsManager *)sharedManager;
- (NSArray *)menuItemsForResult:(DDResultRef)result actionContext:(DDActionContext *)context;
-- (void)unanchorBubbles;
+- (void)requestBubbleClosureUnanchorOnFailure:(BOOL)unanchorOnFailure;
@end
Modified: trunk/Source/WebKit2/ChangeLog (175962 => 175963)
--- trunk/Source/WebKit2/ChangeLog 2014-11-11 19:14:07 UTC (rev 175962)
+++ trunk/Source/WebKit2/ChangeLog 2014-11-11 19:17:11 UTC (rev 175963)
@@ -1,5 +1,20 @@
2014-11-11 Tim Horton <[email protected]>
+ Data Detectors popovers should be dismissed upon scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=138600
+ <rdar://problem/18932770>
+
+ Reviewed by Beth Dakin.
+
+ * UIProcess/mac/WKActionMenuController.mm:
+ (-[WKActionMenuController prepareForMenu:withEvent:]):
+ Dismiss popovers when we start preparing another menu.
+
+ (-[WKActionMenuController dismissActionMenuPopovers]):
+ Use the new DataDetectors SPI.
+
+2014-11-11 Tim Horton <[email protected]>
+
Localize strings for action menus
https://bugs.webkit.org/show_bug.cgi?id=138591
<rdar://problem/18815343>
Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (175962 => 175963)
--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-11 19:14:07 UTC (rev 175962)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm 2014-11-11 19:17:11 UTC (rev 175963)
@@ -176,12 +176,13 @@
return;
}
+ [self dismissActionMenuPopovers];
+
_page->performActionMenuHitTestAtLocation([_wkView convertPoint:event.locationInWindow fromView:nil]);
_state = ActionMenuState::Pending;
[self _updateActionMenuItemsForStage:MenuUpdateStage::PrepareForMenu];
- [self _hideTextIndicator];
_shouldKeepPreviewPopoverOpen = NO;
}
@@ -243,9 +244,7 @@
- (void)dismissActionMenuPopovers
{
- // Ideally, this would actually dismiss the data detector popovers. We don't currently have the ability to request
- // that and know whether or not it succeeded, so we'll settle for unanchoring.
- [[getDDActionsManagerClass() sharedManager] unanchorBubbles];
+ [[getDDActionsManagerClass() sharedManager] requestBubbleClosureUnanchorOnFailure:YES];
[self _hideTextIndicator];
[self _clearPreviewPopover];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
