Title: [175977] trunk/Source/WebInspectorUI
Revision
175977
Author
[email protected]
Date
2014-11-11 14:20:31 -0800 (Tue, 11 Nov 2014)

Log Message

Web Inspector: Main.js missing many trailing semicolons
https://bugs.webkit.org/show_bug.cgi?id=138624

Add semicolons to function variable assignments.

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js: Added semicolons.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (175976 => 175977)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-11-11 22:03:15 UTC (rev 175976)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-11-11 22:20:31 UTC (rev 175977)
@@ -1,3 +1,14 @@
+2014-11-11  Jonathan Wells  <[email protected]>
+
+        Web Inspector: Main.js missing many trailing semicolons
+        https://bugs.webkit.org/show_bug.cgi?id=138624
+
+        Add semicolons to function variable assignments.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Base/Main.js: Added semicolons.
+
 2014-11-10  Jonathan Wells  <[email protected]>
 
         Web Inspector: Update Esprima, remove WebInspector.Esprima global.

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (175976 => 175977)


--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2014-11-11 22:03:15 UTC (rev 175976)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js	2014-11-11 22:20:31 UTC (rev 175977)
@@ -30,7 +30,7 @@
     DatabaseTable: "database-table",
     DOMStorage: "dom-storage",
     Resource: "resource", // includes Frame too.
-    Timelines: "timelines",
+    Timelines: "timelines"
 };
 
 WebInspector.DebuggableType = {
@@ -353,7 +353,7 @@
         this.showSplitConsole();
 
     this._contentLoaded = true;
-}
+};
 
 WebInspector.activateExtraDomains = function(domains)
 {
@@ -369,7 +369,7 @@
     this.notifications.dispatchEventToListeners(WebInspector.Notification.ExtraDomainsActivated);
 
     WebInspector.CSSCompletions.requestCSSNameCompletions();
-}
+};
 
 WebInspector.sidebarPanelForCurrentContentView = function()
 {
@@ -377,7 +377,7 @@
     if (!currentContentView)
         return null;
     return this.sidebarPanelForRepresentedObject(currentContentView.representedObject);
-}
+};
 
 WebInspector.sidebarPanelForRepresentedObject = function(representedObject)
 {
@@ -400,7 +400,7 @@
 
     console.error("Unknown representedObject: ", representedObject);
     return null;
-}
+};
 
 WebInspector.contentBrowserTreeElementForRepresentedObject = function(contentBrowser, representedObject)
 {
@@ -412,7 +412,7 @@
     if (sidebarPanel)
         return sidebarPanel.treeElementForRepresentedObject(representedObject);
     return null;
-}
+};
 
 WebInspector.updateWindowTitle = function()
 {
@@ -441,7 +441,7 @@
     // The name "inspectedURLChanged" sounds like the whole URL is required, however this is only
     // used for updating the window title and it can be any string.
     InspectorFrontendHost.inspectedURLChanged(title);
-}
+};
 
 WebInspector.updateDockedState = function(side)
 {
@@ -485,7 +485,7 @@
 
     this._updateDockNavigationItems();
     this._updateToolbarHeight();
-}
+};
 
 WebInspector.handlePossibleLinkClick = function(event, frame, alwaysOpenExternally)
 {
@@ -505,7 +505,7 @@
     this.openURL(anchorElement.href, frame, false, anchorElement.lineNumber);
 
     return true;
-}
+};
 
 WebInspector.openURL = function(url, frame, alwaysOpenExternally, lineNumber)
 {
@@ -539,7 +539,7 @@
     }
 
     InspectorFrontendHost.openInNewTab(url);
-}
+};
 
 WebInspector.close = function()
 {
@@ -549,23 +549,23 @@
     this._isClosing = true;
 
     InspectorFrontendHost.closeWindow();
-}
+};
 
 WebInspector.isConsoleFocused = function()
 {
     return this.quickConsole.prompt.focused;
-}
+};
 
 WebInspector.isShowingSplitConsole = function()
 {
     return !this.splitContentBrowser.element.classList.contains("hidden");
-}
+};
 
 WebInspector.currentViewSupportsSplitContentBrowser = function()
 {
     var currentContentView = this.contentBrowser.currentContentView;
     return !currentContentView || currentContentView.supportsSplitContentBrowser;
-}
+};
 
 WebInspector.toggleSplitConsole = function()
 {
@@ -578,7 +578,7 @@
         this.hideSplitConsole();
     else
         this.showSplitConsole();
-}
+};
 
 WebInspector.showSplitConsole = function()
 {
@@ -605,7 +605,7 @@
         this.navigationSidebar.collapsed = false;
 
     this.quickConsole.consoleLogVisibilityChanged(true);
-}
+};
 
 WebInspector.hideSplitConsole = function()
 {
@@ -617,7 +617,7 @@
     this.splitContentBrowser.contentViewContainer.hidden();
 
     this.quickConsole.consoleLogVisibilityChanged(false);
-}
+};
 
 WebInspector.showFullHeightConsole = function(scope)
 {
@@ -656,17 +656,17 @@
     console.assert(this._consoleToolbarButton.activated);
 
     this.quickConsole.consoleLogVisibilityChanged(true);
-}
+};
 
 WebInspector.isShowingConsoleView = function()
 {
     return this.contentBrowser.currentContentView instanceof WebInspector.LogContentView;
-}
+};
 
 WebInspector.showConsoleView = function(scope)
 {
     this.showFullHeightConsole(scope);
-}
+};
 
 WebInspector.toggleConsoleView = function()
 {
@@ -683,7 +683,7 @@
             this.navigationSidebar.collapsed = false;
     } else
         this.showFullHeightConsole();
-}
+};
 
 WebInspector.UIString = function(string, vararg)
 {
@@ -702,13 +702,13 @@
     }
 
     return "LOCALIZED STRING NOT FOUND";
-}
+};
 
 WebInspector.restoreFocusFromElement = function(element)
 {
     if (element && element.isSelfOrAncestor(this.currentFocusElement))
         this.previousFocusElement.focus();
-}
+};
 
 WebInspector._focusChanged = function(event)
 {
@@ -739,12 +739,12 @@
 
     selection.removeAllRanges();
     selection.addRange(selectionRange);
-}
+};
 
 WebInspector._mouseWasClicked = function(event)
 {
     this.handlePossibleLinkClick(event);
-}
+};
 
 WebInspector._dragOver = function(event)
 {
@@ -759,12 +759,12 @@
     // Prevent the drop from being accepted.
     event.dataTransfer.dropEffect = "none";
     event.preventDefault();
-}
+};
 
 WebInspector._captureDidStart = function(event)
 {
     this.dashboardContainer.showDashboardViewForRepresentedObject(this.dashboardManager.dashboards.replay);
-}
+};
 
 WebInspector._debuggerDidPause = function(event)
 {
@@ -776,17 +776,17 @@
     this._selectAndShowScopeChainDetailsSidebarPanelWhenAvailable = true;
 
     InspectorFrontendHost.bringToFront();
-}
+};
 
 WebInspector._debuggerDidResume = function(event)
 {
     this.dashboardContainer.closeDashboardViewForRepresentedObject(this.dashboardManager.dashboards.debugger);
-}
+};
 
 WebInspector._mainFrameDidChange = function(event)
 {
     this.updateWindowTitle();
-}
+};
 
 WebInspector._mainResourceDidChange = function(event)
 {
@@ -798,7 +798,7 @@
     this._restoreInspectorViewStateFromCookie(this._lastInspectorViewStateCookieSetting.value, true);
 
     this.updateWindowTitle();
-}
+};
 
 WebInspector._provisionalLoadStarted = function(event)
 {
@@ -808,7 +808,7 @@
     this._updateCookieForInspectorViewState();
 
     this._inProvisionalLoad = true;
-}
+};
 
 WebInspector._windowFocused = function(event)
 {
@@ -817,7 +817,7 @@
 
     // FIXME: We should use the :window-inactive pseudo class once https://webkit.org/b/38927 is fixed.
     document.body.classList.remove("window-inactive");
-}
+};
 
 WebInspector._windowBlurred = function(event)
 {
@@ -826,14 +826,14 @@
 
     // FIXME: We should use the :window-inactive pseudo class once https://webkit.org/b/38927 is fixed.
     document.body.classList.add("window-inactive");
-}
+};
 
 WebInspector._windowResized = function(event)
 {
     this.toolbar.updateLayout();
 
     this._contentBrowserSizeDidChange(event);
-}
+};
 
 WebInspector._updateModifierKeys = function(event)
 {
@@ -843,7 +843,7 @@
 
     if (didChange)
         this.notifications.dispatchEventToListeners(WebInspector.Notification.GlobalModifierKeysDidChange, event);
-}
+};
 
 WebInspector._windowKeyDown = function(event)
 {
@@ -851,7 +851,7 @@
 
     var opposite = !this._dockButtonToggledSetting.value;
     this.undockButtonNavigationItem.toggled = (event.altKey && !event.metaKey && !event.shiftKey) ? opposite : !opposite;
-}
+};
 
 WebInspector._windowKeyUp = function(event)
 {
@@ -859,7 +859,7 @@
 
     var opposite = !this._dockButtonToggledSetting.value;
     this.undockButtonNavigationItem.toggled = (event.altKey && !event.metaKey && !event.shiftKey) ? opposite : !opposite;
-}
+};
 
 WebInspector._mouseMoved = function(event)
 {
@@ -868,12 +868,12 @@
         x: event.pageX,
         y: event.pageY
     };
-}
+};
 
 WebInspector._pageHidden = function(event)
 {
     this._updateCookieForInspectorViewState();
-}
+};
 
 WebInspector._undock = function(event)
 {
@@ -883,7 +883,7 @@
         InspectorFrontendHost.requestSetDockSide(this._dockSide === "bottom" ? "right" : "bottom");
     else
         InspectorFrontendHost.requestSetDockSide("undocked");
-}
+};
 
 WebInspector._updateDockNavigationItems = function()
 {
@@ -898,7 +898,7 @@
     }
 
     this.undockButtonNavigationItem.toggled = this._dockButtonToggledSetting.value;
-}
+};
 
 WebInspector._sidebarCollapsedStateDidChange = function(event)
 {
@@ -909,7 +909,7 @@
         if (!this._ignoreDetailsSidebarPanelCollapsedEvent)
             this._detailsSidebarCollapsedSetting.value = this.detailsSidebar.collapsed;
     }
-}
+};
 
 WebInspector._detailsSidebarPanelSelected = function(event)
 {
@@ -917,7 +917,7 @@
         return;
 
     this._lastSelectedDetailsSidebarPanelSetting.value = this.detailsSidebar.selectedSidebarPanel.identifier;
-}
+};
 
 WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar = function(representedObject)
 {
@@ -945,7 +945,7 @@
 
     if (!selectedSidebarPanel.hasSelectedElement)
         selectedSidebarPanel.showDefaultContentView();
-}
+};
 
 WebInspector._updateNavigationSidebarForCurrentContentView = function()
 {
@@ -974,7 +974,7 @@
         currentContentView.__lastNavigationSidebarPanelIdentifer = selectedSidebarPanel.identifier;
 
     this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
-}
+};
 
 WebInspector._navigationSidebarPanelSelected = function(event)
 {
@@ -983,7 +983,7 @@
         return;
 
     this._updateNavigationSidebarForCurrentContentView();
-}
+};
 
 WebInspector._domNodeWasInspected = function(event)
 {
@@ -994,19 +994,19 @@
         this.detailsSidebar.selectedSidebarPanel = this.cssStyleDetailsSidebarPanel;
 
     InspectorFrontendHost.bringToFront();
-}
+};
 
 WebInspector._contentBrowserSizeDidChange = function(event)
 {
     this.contentBrowser.updateLayout();
     this.splitContentBrowser.updateLayout();
     this.quickConsole.updateLayout();
-}
+};
 
 WebInspector._quickConsoleDidResize = function(event)
 {
     this.contentBrowser.updateLayout();
-}
+};
 
 WebInspector._sidebarWidthDidChange = function(event)
 {
@@ -1018,13 +1018,13 @@
     }
 
     this._contentBrowserSizeDidChange(event);
-}
+};
 
 WebInspector._updateToolbarHeight = function()
 {
     if (WebInspector.Platform.isLegacyMacOS)
         InspectorFrontendHost.setToolbarHeight(this.toolbar.element.offsetHeight);
-}
+};
 
 WebInspector._toolbarDisplayModeDidChange = function(event)
 {
@@ -1039,7 +1039,7 @@
         this._toolbarUndockedDisplayModeSetting.value = this.toolbar.displayMode;
 
     this._updateToolbarHeight();
-}
+};
 
 WebInspector._toolbarSizeModeDidChange = function(event)
 {
@@ -1054,7 +1054,7 @@
         this._toolbarUndockedSizeModeSetting.value = this.toolbar.sizeMode;
 
     this._updateToolbarHeight();
-}
+};
 
 WebInspector._updateCookieForInspectorViewState = function()
 {
@@ -1084,7 +1084,7 @@
     cookie[WebInspector.SelectedSidebarPanelCookieKey] = selectedSidebarPanel.identifier;
     selectedSidebarPanel.saveStateToCookie(cookie);
     this._lastInspectorViewStateCookieSetting.value = cookie;
-}
+};
 
 WebInspector._contentBrowserCurrentContentViewDidChange = function(event)
 {
@@ -1119,7 +1119,7 @@
         currentContentView.__lastNavigationSidebarPanelIdentifer = selectedSidebarPanelIdentifier;
 
     this._revealAndSelectRepresentedObjectInNavigationSidebar(currentContentView.representedObject);
-}
+};
 
 WebInspector._contentBrowserRepresentedObjectsDidChange = function(event)
 {
@@ -1177,7 +1177,7 @@
 
     // Stop ignoring the sidebar panel selected event.
     delete this._ignoreDetailsSidebarPanelSelectedEvent;
-}
+};
 
 WebInspector._restoreInspectorViewStateFromCookie = function(cookie, causedByReload)
 {
@@ -1206,7 +1206,7 @@
 
     var relaxMatchDelay = causedByReload ? matchTypeOnlyDelayForReload : matchTypeOnlyDelayForReopen;
     sidebarPanel.restoreStateFromCookie(cookie, relaxMatchDelay);
-}
+};
 
 WebInspector._initializeWebSocketIfNeeded = function()
 {
@@ -1227,7 +1227,7 @@
         return;
 
     InspectorFrontendHost.initializeWebSocket(url);
-}
+};
 
 WebInspector._updateSplitConsoleHeight = function(height)
 {
@@ -1237,7 +1237,7 @@
     height = Math.max(minimumHeight, Math.min(height, maximumHeight));
 
     this.splitContentBrowser.element.style.height = height + "px";
-}
+};
 
 WebInspector._consoleResizerMouseDown = function(event)
 {
@@ -1272,7 +1272,7 @@
     }
 
     this.elementDragStart(resizerElement, dockedResizerDrag.bind(this), dockedResizerDragEnd.bind(this), event, "row-resize");
-}
+};
 
 WebInspector._toolbarMouseDown = function(event)
 {
@@ -1286,7 +1286,7 @@
         this._dockedResizerMouseDown(event);
     else
         this._moveWindowMouseDown(event);
-}
+};
 
 WebInspector._dockedResizerMouseDown = function(event)
 {
@@ -1347,7 +1347,7 @@
     }
 
     WebInspector.elementDragStart(resizerElement, dockedResizerDrag.bind(this), dockedResizerDragEnd.bind(this), event, this._dockSide === "bottom" ? "row-resize" : "col-resize");
-}
+};
 
 WebInspector._moveWindowMouseDown = function(event)
 {
@@ -1394,32 +1394,32 @@
     }
 
     WebInspector.elementDragStart(event.target, toolbarDrag, toolbarDragEnd, event, "default");
-}
+};
 
 WebInspector._inspectModeStateChanged = function(event)
 {
     this._inspectModeToolbarButton.activated = WebInspector.domTreeManager.inspectModeEnabled;
-}
+};
 
 WebInspector._toggleInspectMode = function(event)
 {
     WebInspector.domTreeManager.inspectModeEnabled = !WebInspector.domTreeManager.inspectModeEnabled;
-}
+};
 
 WebInspector._reloadPage = function(event)
 {
     PageAgent.reload();
-}
+};
 
 WebInspector._reloadPageIgnoringCache = function(event)
 {
     PageAgent.reload(true);
-}
+};
 
 WebInspector._toggleInspectMode = function(event)
 {
     this.domTreeManager.inspectModeEnabled = !this.domTreeManager.inspectModeEnabled;
-}
+};
 
 WebInspector._focusedContentView = function()
 {
@@ -1428,7 +1428,7 @@
     if (this.splitContentBrowser.element.isSelfOrAncestor(this.currentFocusElement))
         return  this.splitContentBrowser.currentContentView;
     return null;
-}
+};
 
 WebInspector._beforecopy = function(event)
 {
@@ -1457,7 +1457,7 @@
 
     // Say we can handle it (by preventing default) to remove word break characters.
     event.preventDefault();
-}
+};
 
 WebInspector._copy = function(event)
 {
@@ -1488,7 +1488,7 @@
     var selectionString = selection.toString().removeWordBreakCharacters();
     event.clipboardData.setData("text/plain", selectionString);
     event.preventDefault();
-}
+};
 
 WebInspector._generateDisclosureTriangleImages = function()
 {
@@ -1503,7 +1503,7 @@
 
     generateColoredImagesForCSS("Images/DisclosureTriangleTinyOpen.svg", specifications, 8, 8, "disclosure-triangle-tiny-open-");
     generateColoredImagesForCSS("Images/DisclosureTriangleTinyClosed.svg", specifications, 8, 8, "disclosure-triangle-tiny-closed-");
-}
+};
 
 WebInspector.elementDragStart = function(element, dividerDrag, elementDragEnd, event, cursor, eventTarget)
 {
@@ -1534,7 +1534,7 @@
     targetDocument.body.style.cursor = cursor;
 
     event.preventDefault();
-}
+};
 
 WebInspector.elementDragEnd = function(event)
 {
@@ -1552,7 +1552,7 @@
     delete WebInspector._elementEndDraggingEventListener;
 
     event.preventDefault();
-}
+};
 
 WebInspector.createMessageTextView = function(message, isError)
 {
@@ -1564,7 +1564,7 @@
     messageElement.textContent = message;
 
     return messageElement;
-}
+};
 
 WebInspector.createGoToArrowButton = function()
 {
@@ -1590,7 +1590,7 @@
     button.className = "go-to-arrow";
     button.tabIndex = -1;
     return button;
-}
+};
 
 WebInspector.createSourceCodeLocationLink = function(sourceCodeLocation, dontFloat, useGoToArrowButton)
 {
@@ -1623,7 +1623,7 @@
         linkElement.classList.add("dont-float");
 
     return linkElement;
-}
+};
 
 WebInspector.linkifyLocation = function(url, lineNumber, columnNumber, className)
 {
@@ -1649,7 +1649,7 @@
     if (className)
         linkElement.classList.add(className);
     return linkElement;
-}
+};
 
 WebInspector.linkifyURLAsNode = function(url, linkText, classes, tooltipText)
 {
@@ -1671,7 +1671,7 @@
     a.style.maxWidth = "100%";
 
     return a;
-}
+};
 
 WebInspector.linkifyStringAsFragmentWithCustomLinkifier = function(string, linkifier)
 {
@@ -1704,7 +1704,7 @@
         container.appendChild(document.createTextNode(string));
 
     return container;
-}
+};
 
 WebInspector.linkifyStringAsFragment = function(string)
 {
@@ -1718,7 +1718,7 @@
     }
 
     return WebInspector.linkifyStringAsFragmentWithCustomLinkifier(string, linkifier);
-}
+};
 
 WebInspector._undoKeyboardShortcut = function(event)
 {
@@ -1726,7 +1726,7 @@
         this.undo();
         event.preventDefault();
     }
-}
+};
 
 WebInspector._redoKeyboardShortcut = function(event)
 {
@@ -1734,17 +1734,17 @@
         this.redo();
         event.preventDefault();
     }
-}
+};
 
 WebInspector.undo = function()
 {
     DOMAgent.undo();
-}
+};
 
 WebInspector.redo = function()
 {
     DOMAgent.redo();
-}
+};
 
 WebInspector.highlightRangesWithStyleClass = function(element, resultRanges, styleClass, changes)
 {
@@ -1823,7 +1823,7 @@
 
     }
     return highlightNodes;
-}
+};
 
 WebInspector.revertDomChanges = function(domChanges)
 {
@@ -1839,7 +1839,7 @@
             break;
         }
     }
-}
+};
 
 WebInspector.archiveMainFrame = function()
 {
@@ -1857,7 +1857,7 @@
             InspectorFrontendHost.save(url, data, true, true);
         }.bind(this));
     }.bind(this), 3000);
-}
+};
 
 WebInspector.canArchiveMainFrame = function()
 {
@@ -1865,7 +1865,7 @@
         return false;
 
     return WebInspector.Resource.typeFromMIMEType(WebInspector.frameResourceManager.mainFrame.mainResource.mimeType) === WebInspector.Resource.Type.Document;
-}
+};
 
 WebInspector.addWindowKeydownListener = function(listener)
 {
@@ -1890,7 +1890,7 @@
         window.addEventListener("keydown", WebInspector._sharedWindowKeydownListener, true);
     else
         window.removeEventListener("keydown", WebInspector._sharedWindowKeydownListener, true);
-}
+};
 
 WebInspector._sharedWindowKeydownListener = function(event)
 {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to