Title: [175991] trunk/Tools
- Revision
- 175991
- Author
- [email protected]
- Date
- 2014-11-11 16:46:41 -0800 (Tue, 11 Nov 2014)
Log Message
webkit-patch --suggest-reviewers is broken with newer versions of git
<http://webkit.org/b/138627>
Reviewed by Michael Saboff with feedback from Daniel Bates.
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git._changes_files_for_commit): Strip blank lines instead of
assuming there is always a blank line at the beginning of the
list.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (175990 => 175991)
--- trunk/Tools/ChangeLog 2014-11-12 00:23:18 UTC (rev 175990)
+++ trunk/Tools/ChangeLog 2014-11-12 00:46:41 UTC (rev 175991)
@@ -1,3 +1,15 @@
+2014-11-11 David Kilzer <[email protected]>
+
+ webkit-patch --suggest-reviewers is broken with newer versions of git
+ <http://webkit.org/b/138627>
+
+ Reviewed by Michael Saboff with feedback from Daniel Bates.
+
+ * Scripts/webkitpy/common/checkout/scm/git.py:
+ (Git._changes_files_for_commit): Strip blank lines instead of
+ assuming there is always a blank line at the beginning of the
+ list.
+
2014-11-11 Alexey Proskuryakov <[email protected]>
DRT and WKTR touch disk cache
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (175990 => 175991)
--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2014-11-12 00:23:18 UTC (rev 175990)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2014-11-12 00:46:41 UTC (rev 175991)
@@ -223,10 +223,10 @@
return self.run_status_and_extract_filenames(status_command, self._status_regexp("ADM"))
def _changes_files_for_commit(self, git_commit):
- # --pretty="format:" makes git show not print the commit log header,
- changed_files = self._run_git(["show", "--pretty=format:", "--name-only", git_commit]).splitlines()
- # instead it just prints a blank line at the top, so we skip the blank line:
- return changed_files[1:]
+ # --pretty="format:" makes git show not print the commit log header.
+ changed_files = self._run_git(["show", "--pretty=format:", "--name-only", git_commit])
+ # Strip blank lines which could appear at the top on older versions of git.
+ return changed_files.lstrip().splitlines()
def changed_files_for_revision(self, revision):
commit_id = self.git_commit_from_svn_revision(revision)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
