Title: [175996] trunk/Source/WebKit/mac
- Revision
- 175996
- Author
- [email protected]
- Date
- 2014-11-11 17:29:43 -0800 (Tue, 11 Nov 2014)
Log Message
Action menu hit testing is not working properly with all WK1 apps
https://bugs.webkit.org/show_bug.cgi?id=138643
-and corresponding-
rdar://problem/18949376
Reviewed by Tim Horton.
* WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _lookupText:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (175995 => 175996)
--- trunk/Source/WebKit/mac/ChangeLog 2014-11-12 01:20:30 UTC (rev 175995)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-11-12 01:29:43 UTC (rev 175996)
@@ -1,3 +1,16 @@
+2014-11-11 Beth Dakin <[email protected]>
+
+ Action menu hit testing is not working properly with all WK1 apps
+ https://bugs.webkit.org/show_bug.cgi?id=138643
+ -and corresponding-
+ rdar://problem/18949376
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebActionMenuController.mm:
+ (-[WebActionMenuController prepareForMenu:withEvent:]):
+ (-[WebActionMenuController _lookupText:]):
+
2014-11-11 Myles C. Maxfield <[email protected]>
Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
Modified: trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm (175995 => 175996)
--- trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm 2014-11-12 01:20:30 UTC (rev 175995)
+++ trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm 2014-11-12 01:29:43 UTC (rev 175996)
@@ -117,7 +117,7 @@
[actionMenu removeAllItems];
- WebElementDictionary *hitTestResult = [self performHitTestAtPoint:[_webView convertPoint:event.locationInWindow fromView:nil]];
+ WebElementDictionary *hitTestResult = [self performHitTestAtPoint:event.locationInWindow];
NSArray *menuItems = [self _defaultMenuItemsForHitTestResult:hitTestResult];
// Allow clients to customize the menu items.
@@ -336,7 +336,6 @@
NSPoint textBaselineOrigin = popupInfo.origin;
// Convert to screen coordinates.
- textBaselineOrigin = [_webView convertPoint:textBaselineOrigin toView:nil];
textBaselineOrigin = [_webView.window convertRectToScreen:NSMakeRect(textBaselineOrigin.x, textBaselineOrigin.y, 0, 0)].origin;
WKShowWordDefinitionWindow(popupInfo.attributedString.get(), textBaselineOrigin, popupInfo.options.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
