Title: [176100] trunk/Source/_javascript_Core
Revision
176100
Author
[email protected]
Date
2014-11-13 15:43:46 -0800 (Thu, 13 Nov 2014)

Log Message

Change X86/64 JIT probes to save/restore xmm regs as double instead of __m128. [Follow up]
<https://webkit.org/b/138708>

Reviewed by Michael Saboff.

Removed a stale comment and a now unnecessary #include. 

* assembler/X86Assembler.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (176099 => 176100)


--- trunk/Source/_javascript_Core/ChangeLog	2014-11-13 23:30:45 UTC (rev 176099)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-11-13 23:43:46 UTC (rev 176100)
@@ -1,3 +1,14 @@
+2014-11-13  Mark Lam  <[email protected]>
+
+        Change X86/64 JIT probes to save/restore xmm regs as double instead of __m128. [Follow up]
+        <https://webkit.org/b/138708>
+
+        Reviewed by Michael Saboff.
+
+        Removed a stale comment and a now unnecessary #include. 
+
+        * assembler/X86Assembler.h:
+
 2014-11-13  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r176087.

Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (176099 => 176100)


--- trunk/Source/_javascript_Core/assembler/X86Assembler.h	2014-11-13 23:30:45 UTC (rev 176099)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h	2014-11-13 23:43:46 UTC (rev 176100)
@@ -35,10 +35,6 @@
 #include <wtf/Assertions.h>
 #include <wtf/Vector.h>
 
-#if ENABLE(MASM_PROBE)
-#include <xmmintrin.h>
-#endif
-
 namespace JSC {
 
 inline bool CAN_SIGN_EXTEND_8_32(int32_t value) { return value == (int32_t)(signed char)value; }
@@ -68,10 +64,7 @@
     V(void*, eip) \
     V(void*, eflags) \
 
-// Note: the JITs only stores double values in the FP registers. However, the
-// storage type here is defined as __m128 because the JIT probe code which does
-// the storing still expects a __m128 slot. This will be changed when the JIT
-// probe code is updated later to reflect the JITs' usage of these registers.
+// Note: the JITs only stores double values in the FP registers.
 #define FOR_EACH_CPU_FPREGISTER(V) \
     V(double, xmm0) \
     V(double, xmm1) \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to