Title: [176104] trunk/Tools
- Revision
- 176104
- Author
- [email protected]
- Date
- 2014-11-13 16:33:03 -0800 (Thu, 13 Nov 2014)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=138628
A patch that doesn't apply is stuck in commit queue
Rubber-stamped by David Kilzer.
This also hopefully fixes other issues:
- a patch that has cq+ flag set by a non-committer kills commit queue;
- EWS never reports failing tests, and keeps spinning instead.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
Apply the fix from r174797 to more places.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (176103 => 176104)
--- trunk/Tools/ChangeLog 2014-11-14 00:10:11 UTC (rev 176103)
+++ trunk/Tools/ChangeLog 2014-11-14 00:33:03 UTC (rev 176104)
@@ -1,3 +1,19 @@
+2014-11-13 Alexey Proskuryakov <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=138628
+ A patch that doesn't apply is stuck in commit queue
+
+ Rubber-stamped by David Kilzer.
+
+ This also hopefully fixes other issues:
+ - a patch that has cq+ flag set by a non-committer kills commit queue;
+ - EWS never reports failing tests, and keeps spinning instead.
+
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ (Bugzilla.set_flag_on_attachment):
+ (Bugzilla.obsolete_attachment):
+ Apply the fix from r174797 to more places.
+
2014-11-13 Dan Bernstein <[email protected]>
Policy client not called for navigations through the page cache
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (176103 => 176104)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2014-11-14 00:10:11 UTC (rev 176103)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2014-11-14 00:33:03 UTC (rev 176104)
@@ -771,7 +771,7 @@
self.browser.select_form(nr=1)
if comment_text:
- self.browser.set_value(comment_text, name='comment', nr=0)
+ self.browser.set_value(comment_text, name='comment', nr=1)
self._find_select_element_for_flag(flag_name).value = (flag_value,)
self.browser.submit()
@@ -793,7 +793,7 @@
_log.info(comment_text)
# Bugzilla has two textareas named 'comment', one is somehow
# hidden. We want the first.
- self.browser.set_value(comment_text, name='comment', nr=0)
+ self.browser.set_value(comment_text, name='comment', nr=1)
self.browser.submit()
def add_cc_to_bug(self, bug_id, email_address_list):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
