Diff
Modified: trunk/LayoutTests/ChangeLog (176121 => 176122)
--- trunk/LayoutTests/ChangeLog 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/ChangeLog 2014-11-14 11:27:54 UTC (rev 176122)
@@ -1,3 +1,20 @@
+2014-11-14 Andrzej Badowski <[email protected]>
+
+ AX: Improve AccessibilityTableCell isColumnHeaderCell function.
+ https://bugs.webkit.org/show_bug.cgi?id=138423
+
+ Reviewed by Chris Fleizach.
+
+ Files of expected type are adapted to changes in the code of the function.
+
+ * accessibility/table-cells-roles-expected.txt:
+ * platform/efl/accessibility/table-attributes-expected.txt:
+ * platform/efl/accessibility/table-cells-expected.txt:
+ * platform/gtk/accessibility/table-attributes-expected.txt:
+ * platform/gtk/accessibility/table-cells-expected.txt:
+ * platform/mac/accessibility/table-attributes-expected.txt:
+ * platform/mac/accessibility/table-cells-expected.txt:
+
2014-11-14 Carlos Garcia Campos <[email protected]>
Unreviewed GTK+ gardening. Skip http/tests/appcache/auth.html after r175776.
Modified: trunk/LayoutTests/accessibility/table-cells-roles-expected.txt (176121 => 176122)
--- trunk/LayoutTests/accessibility/table-cells-roles-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/accessibility/table-cells-roles-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -21,7 +21,7 @@
The table cell at (0,2) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
The table cell at (0,4) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
-The table2 cell at (2,0) should have a role AXRole: AXColumnHeader , currently it has AXRole: AXCell .
+The table2 cell at (2,0) should have a role AXRole: AXColumnHeader , currently it has AXRole: AXColumnHeader .
The table2 cell at (1,2) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
The table2 cell at (2,3) should have a role AXRole: AXCell , currently it has AXRole: AXCell .
The table2 cell at (0,2) should have a role AXRole: AXRowHeader , currently it has AXRole: AXRowHeader .
Modified: trunk/LayoutTests/platform/efl/accessibility/table-attributes-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/efl/accessibility/table-attributes-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/efl/accessibility/table-attributes-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -8,7 +8,7 @@
South 3333 1111 2222
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -18,7 +18,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -27,7 +27,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -37,7 +37,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -46,7 +46,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -56,7 +56,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -65,7 +65,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -75,7 +75,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -84,7 +84,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -94,7 +94,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -107,7 +107,7 @@
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -117,7 +117,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -126,7 +126,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -136,7 +136,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -195,7 +195,7 @@
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -205,7 +205,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -214,7 +214,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -224,7 +224,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -233,7 +233,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -243,7 +243,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -252,7 +252,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -262,7 +262,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -271,7 +271,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -281,7 +281,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -290,7 +290,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -300,7 +300,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -309,7 +309,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -319,7 +319,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -328,7 +328,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitEfl
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -338,7 +338,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
Modified: trunk/LayoutTests/platform/efl/accessibility/table-cells-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/efl/accessibility/table-cells-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/efl/accessibility/table-cells-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -10,7 +10,7 @@
South 3333 1111 2222
------------------------
[0,0]
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -20,7 +20,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -50,7 +50,7 @@
AXPlatformAttributes: toolkit:WebKitEfl
------------------------
[1,1]
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 0.000000, 0.000000 }
@@ -60,7 +60,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
Modified: trunk/LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -8,7 +8,7 @@
South 3333 1111 2222
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 235.000000, 26.000000 }
@@ -18,7 +18,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -27,7 +27,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 235.000000, 26.000000 }
@@ -37,7 +37,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -46,7 +46,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 378.000000, 26.000000 }
@@ -56,7 +56,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -65,7 +65,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 447.000000, 26.000000 }
@@ -75,7 +75,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -84,7 +84,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 447.000000, 26.000000 }
@@ -94,7 +94,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -107,7 +107,7 @@
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -117,7 +117,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -126,7 +126,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -136,7 +136,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -195,7 +195,7 @@
--------------------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -205,7 +205,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -214,7 +214,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -224,7 +224,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -233,7 +233,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 370.000000, 26.000000 }
@@ -243,7 +243,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -252,7 +252,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 439.000000, 26.000000 }
@@ -262,7 +262,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -271,7 +271,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 439.000000, 26.000000 }
@@ -281,7 +281,7 @@
AXValue: By Gender
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -290,7 +290,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -300,7 +300,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -309,7 +309,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -319,7 +319,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -328,7 +328,7 @@
AXChecked: 0
AXPlatformAttributes: toolkit:WebKitGtk
------------
-AXRole: AXCell
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 370.000000, 26.000000 }
@@ -338,7 +338,7 @@
AXValue: All<\n>Genders
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
Modified: trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/gtk/accessibility/table-cells-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -10,7 +10,7 @@
South 3333 1111 2222
------------------------
[0,0]
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 235.000000, 26.000000 }
@@ -20,7 +20,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
@@ -50,7 +50,7 @@
AXPlatformAttributes: toolkit:WebKitGtk
------------------------
[1,1]
-AXRole: AXRowHeader
+AXRole: AXColumnHeader
AXParent: AXTable: Example #1: Nested Stubs
AXChildren: 0
AXPosition: { 227.000000, 26.000000 }
@@ -60,7 +60,7 @@
AXValue: Ruritanian<\n>Population <\n>Survey
AXFocusable: 0
AXFocused: 0
-AXSelectable: 1
+AXSelectable: 0
AXSelected: 0
AXMultiSelectable: 0
AXEnabled: 1
Modified: trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/mac/accessibility/table-attributes-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -230,7 +230,7 @@
AXDOMClassList: <array of size 1>
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -262,7 +262,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 0>
AXElementBusy: 0
AXRequired: 0
@@ -294,7 +294,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -701,7 +701,7 @@
AXDOMClassList: <array of size 1>
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -733,7 +733,7 @@
AXDOMClassList: <array of size 1>
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {4, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -765,7 +765,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 2}
AXColumnIndexRange: NSRange: {0, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 0>
AXElementBusy: 0
AXRequired: 0
@@ -797,7 +797,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {1, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -829,7 +829,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -861,7 +861,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -893,7 +893,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {4, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -925,7 +925,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {1, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -957,7 +957,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {2, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -989,7 +989,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -1021,7 +1021,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {3, 1}
AXColumnIndexRange: NSRange: {4, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
Modified: trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt (176121 => 176122)
--- trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/LayoutTests/platform/mac/accessibility/table-cells-expected.txt 2014-11-14 11:27:54 UTC (rev 176122)
@@ -69,7 +69,7 @@
AXDOMClassList: <array of size 1>
AXRowIndexRange: NSRange: {1, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -135,7 +135,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {2, 1}
AXColumnIndexRange: NSRange: {2, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
@@ -168,7 +168,7 @@
AXDOMClassList: <array of size 0>
AXRowIndexRange: NSRange: {5, 1}
AXColumnIndexRange: NSRange: {3, 1}
-AXColumnHeaderUIElements: <array of size 0>
+AXColumnHeaderUIElements: <array of size 1>
AXRowHeaderUIElements: <array of size 1>
AXElementBusy: 0
AXRequired: 0
Modified: trunk/Source/WebCore/ChangeLog (176121 => 176122)
--- trunk/Source/WebCore/ChangeLog 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/Source/WebCore/ChangeLog 2014-11-14 11:27:54 UTC (rev 176122)
@@ -1,3 +1,17 @@
+2014-11-14 Andrzej Badowski <[email protected]>
+
+ AX: Improve AccessibilityTableCell isColumnHeaderCell function.
+ https://bugs.webkit.org/show_bug.cgi?id=138423
+
+ Reviewed by Chris Fleizach.
+
+ <th> cell in the zero row should be column header.
+
+ New tests are not necessary.
+
+ * accessibility/AccessibilityTableCell.cpp:
+ (WebCore::AccessibilityTableCell::isColumnHeaderCell):
+
2014-11-14 Carlos Garcia Campos <[email protected]>
[SOUP] Use GMainLoopSource for request timeout in ResourceHandle
Modified: trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp (176121 => 176122)
--- trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp 2014-11-14 10:33:58 UTC (rev 176121)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp 2014-11-14 11:27:54 UTC (rev 176122)
@@ -152,13 +152,13 @@
// We are in a situation after checking the scope attribute.
// It is an attempt to resolve the type of th element without support in the specification.
- // Checking tableTag allows to check the case of direct row placement in the table and lets stop the loop at the table level.
+ // Checking tableTag and tbodyTag allows to check the case of direct row placement in the table and lets stop the loop at the table level.
for (Node* parentNode = node(); parentNode; parentNode = parentNode->parentNode()) {
if (parentNode->hasTagName(theadTag))
return true;
- if (parentNode->hasTagName(tbodyTag) || parentNode->hasTagName(tfootTag))
+ if (parentNode->hasTagName(tfootTag))
return false;
- if (parentNode->hasTagName(tableTag)) {
+ if (parentNode->hasTagName(tableTag) || parentNode->hasTagName(tbodyTag)) {
std::pair<unsigned, unsigned> rowRange;
rowIndexRange(rowRange);
if (!rowRange.first)
